Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding new variant, invalid color value is not handled #82

Closed
prichter opened this issue Mar 3, 2023 · 0 comments
Closed

When adding new variant, invalid color value is not handled #82

prichter opened this issue Mar 3, 2023 · 0 comments

Comments

@prichter
Copy link
Contributor

prichter commented Mar 3, 2023

If you add a new color variant to a color, and add gibberish or an invalid CSS color, there is no warning, and variant appears as white-on-white. Suggest validation error (eg input turning red) on invalid css submission.
@prichter prichter mentioned this issue Mar 3, 2023
Merged
alexdanilowicz added a commit that referenced this issue Mar 4, 2023
@prichter @alexdanilowicz
Issue #82 - Handle invalid colors in variant modals (#86)
ed5a774 
* Added color validation to AddVariantModal and EditVariantModal for empty / invalid strings

* Formatting

---------

Co-authored-by: Paul Richter <paul@vtsw.com.au>
Co-authored-by: alexdanilowicz <alex.danilowicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prichter @alexdanilowicz