Issue #82 - Handle invalid colors in variant modals #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty / invalid strings
|
Just qa-ed, and pushed up some formatting because I don't think you have prettier set up. (DM-ed you about this). Fantastic work yet again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a fix for issue #82. Previously, saving a new or edited variant color would permit, and save, invalid CSS color values. This fix adds error checking and Input highlighting prior to save, following the same convention as in the onboarding name page.
Description
Implementation is the same in both the
AddVariantModaland theEditVariantModalin that an error variable is created, and used to highlight incorrect / missing syntax on the color inputs within the modal. A new Text Chakra component is added beneath each input to display relevant error message.The validation is done by saving the initial value, and applying the handleInvalidCss util to the input color, then checking for differences, and setting the error message in the event that there is a difference (ie. the handleInvalidCss has changed the value).