can't get ghub to work with GHE

[donahchoo]

Hi, I'm using a GHE well trying. I'm not an emacs expert so it is probably just me not understanding how to setup the config and then test. Perhaps @diasjorge and @whirm can share their config and testing instructions?

I've tired manually created my .authinfo but I'm still prompted for the wizard and the wizard wants to use api.github.com instead of my GHE instance... Help?

.gitconfig:

[github "foo.bar.com/api/v3"]
        user = donahchoo

.authinfo:

machine foo.bar.com/api/v3 login donahchoo^ghub password TOKEN

try a get:

(ghub-get "/users/donahchoo/repos")

Result:

Such a Github API token is not available:                                                                
                                                                                                         
  Host:    api.github.com                                                                                
  User:    donahchoo                                                                                       
  Package: ghub                                                                                          

[diasjorge]

I wrote an explanation in my blog how to do it: https://mrdias.com/2018/04/01/using-magit-with-github-enterprise.html

Anyway I think if you're getting prompted for a token it might be you haven't configured the ghub.host for the repo you're visiting. https://magit.vc/manual/ghub/Setting-the-Username.html#Setting-the-Username

[donahchoo]

Thanks @diasjorge! Much closer now... I'm not sure where the problem was. However, when I try to list the issues I'm prompted for my username and password. Then I get this:

HTTP Error: 400, "Bad Request", "and Github didn't return JSON"

All the URLs look correct, but I don't understand why I'm getting prompted for my username and password if I have the ~/.authinfo setup...

machine github.foo.bar.com/api/v3 login donahchoo^ghub password TOKEN
machine github.foo.bar.com/api/v3 login donahchoo\^magithub password TOKEN

Also, I have my username set:

[github "github.foo.bar.com/api/v3"]
        user = donahchoo
[github]
        user = donahchoo

Thoughts?

[vermiculus]

If you're getting HTTP 400, I'd be curious to see the full request. Not sure how to go about that with url though.

[vermiculus]

Not without debugging ghub.

[donahchoo]

@vermiculus I can try to debug ghub. Just need to know how.

I'm also pretty sure this is SSO related which is why I opened the other issue...

[vermiculus]

Instrument ghub-request and just step through. Elisp has a decent debugger.

[diasjorge]

You’ll need to setup a token for regular github or it will prompt all the time. Also try just ^ instead of \^

…

On 2 Apr 2018, at 03:05, donahchoo ***@***.***> wrote: Thanks @diasjorge! Much closer now... I'm not sure where the problem was. However, when I try to list the issues I'm prompted for my username and password. Then I get this: HTTP Error: 400, "Bad Request", "and Github didn't return JSON" All the URLs look correct, but I don't understand why I'm getting prompted for my username and password if I have the ~/.authinfo setup... machine github.foo.bar.com/api/v3 login donahchoo^ghub password TOKEN machine github.foo.bar.com/api/v3 login donahchoo\^magithub password TOKEN Thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[donahchoo]

Thanks @@diasjorge.  The \^ was a copy paste from error from emacs.  I just have ^. I do also have a github.com token, I just didn’t include it. From: Jorge Dias <notifications@github.com> Reply-To: magit/ghub <reply@reply.github.com> Date: Monday, April 2, 2018 at 2:31 AM To: magit/ghub <ghub@noreply.github.com> Cc: donahchoo <donahchoo@me.com>, Author <author@noreply.github.com> Subject: Re: [magit/ghub] can't get ghub to work with GHE (#53) You’ll need to setup a token for regular github or it will prompt all the time. Also try just ^ instead of \^

On 2 Apr 2018, at 03:05, donahchoo ***@***.***> wrote: Thanks @diasjorge! Much closer now... I'm not sure where the problem was. However, when I try to list the issues I'm prompted for my username and password. Then I get this: HTTP Error: 400, "Bad Request", "and Github didn't return JSON" All the URLs look correct, but I don't understand why I'm getting prompted for my username and password if I have the ~/.authinfo setup... machine github.foo.bar.com/api/v3 login donahchoo^ghub password TOKEN machine github.foo.bar.com/api/v3 login donahchoo\^magithub password TOKEN Thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[diasjorge]

You could use M-x eval-expression and execute the following expression on the magit-status buffer. (ghub--host) and see if it's making the request to the right host.

[donahchoo]

going to close this! I think @diasjorge blog did the trick!

[tarsius]

Ah! The things blog posts can do that the official manual can not... (The tip about includeIf is very useful, but everything else is covered by the manual.)

You are not saying what eventually fixed the problem, but for future reference, I think it is that you did eventually set ghub.host. Without that ghub tries to access api.github.com.

[donahchoo]

@tarsius the manual is a great reference and it awesome you have documentation. However it is not substitute for a step by step guide for how to do things. I read the manual several times and couldn't get things to work. The blog post also talks about having an entry for github.com and your GHE instance. I think that made the difference. I'm not finding that I set ghub.host, unless that comes from .authinfo.

[tarsius]

I have improved the manual, the "Getting Started" node and the first two points in "Interactively...". Please have another look - does that address the things that previously were unclear?

7f23879