-
-
Notifications
You must be signed in to change notification settings - Fork 805
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
magit-section-cycle: Pivot to tab-next if there is a binding conflict
If `tab-bar-mode' is enable, then "C-<tab>" is bound to `tab-next' in the global map. That conflicts with our local (and much older) binding for `magit-section-cycle'. Address this conflict by teaching `magit-section-cycle' to pivot to `tab-next', but only if `tab-bar-mode' is enabled. That way, users who do not use `tab-bar-mode' (i.e., the majority), are not affected by this unfortunate conflict. `tab-bar-mode' users will have to get used to the much less convenient "C-c TAB" binding to cycle section visibility. Alternatively they can advice `tab-bar--define-keys' to bind another key to `tab-next'. It would be nice if `tab-bar-mode', instead of modifying the global map, used a mode map, and thus didn't make it so very hard to change its key bindings.
- Loading branch information
Showing
3 changed files
with
46 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters