Skip to content

Commit

Permalink
magit-jump-*-pushremote: Restore functionality
Browse files Browse the repository at this point in the history
`magit-define-section-jumper' uses `magit-get-section', which in turn
uses `magit-section-ident-value', which for these sections implements
the fake values containing "@{push}".  We therefore have to use these
same fake values in the jumper definitions.

Closes #5029.
  • Loading branch information
tarsius committed Oct 14, 2023
1 parent 22c9983 commit c6a62ac
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions lisp/magit-log.el
Original file line number Diff line number Diff line change
Expand Up @@ -1857,8 +1857,7 @@ in the pushremote case."
(magit-log-insert-child-count))))

(magit-define-section-jumper magit-jump-to-unpulled-from-pushremote
"Unpulled from <push-remote>" unpulled
(concat ".." (magit-get-push-branch)))
"Unpulled from <push-remote>" unpulled "..@{push}")

(defun magit-insert-unpulled-from-pushremote ()
"Insert commits that haven't been pulled from the push-remote yet."
Expand Down Expand Up @@ -1929,8 +1928,7 @@ Show the last `magit-log-section-commit-count' commits."
magit-buffer-log-args))))))

(magit-define-section-jumper magit-jump-to-unpushed-to-pushremote
"Unpushed to <push-remote>" unpushed
(concat (magit-get-push-branch) ".."))
"Unpushed to <push-remote>" unpushed "@{push}..")

(defun magit-insert-unpushed-to-pushremote ()
"Insert commits that haven't been pushed to the push-remote yet."
Expand Down

0 comments on commit c6a62ac

Please sign in to comment.