Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magit-insert-status-headers/magit-rev-format doesn't handle upstream gone #1740

Closed
Silex opened this issue Feb 25, 2015 · 2 comments
Closed
Milestone

Comments

@Silex
Copy link
Contributor

Silex commented Feb 25, 2015

See #1739 for more details.

Basically in magit-insert-status-headers, there is the following lines:

              (setq line (or (magit-rev-format "%h %s" upstream) ""))
              (string-match "^\\([^ ]+\\) \\(.*\\)" line)
              (magit-bind-match-strings (hash msg) line

This fails when the upstream was deleted.

I think the following should be enough to reproduce:

git checkout -b foo
git push -u origin foo
git push origin :foo
emacs -f magit-status

I would have liked to fix it myself but I can't figure out what to do 😞

@npostavs
Copy link
Contributor

I think this is a duplicate of #1723, there is a proposed patch in the comments there.

@Silex
Copy link
Contributor Author

Silex commented Feb 25, 2015

Oh, nice!

@Silex Silex closed this as completed Feb 25, 2015
@tarsius tarsius modified the milestone: 2.1.0 Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants