Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In log view, the latest commit has no author/date information #1951

Closed
tshatrov opened this issue Jul 2, 2015 · 5 comments
Closed

In log view, the latest commit has no author/date information #1951

tshatrov opened this issue Jul 2, 2015 · 5 comments
Labels
bug windows Something isn't working on Windows
Milestone

Comments

@tshatrov
Copy link

tshatrov commented Jul 2, 2015

magit log bug

Note the topmost commit lacking name/date.

This is Emacs 24.4.1 on Windows. I don't think I had this bug on my Linux/Emacs 25 setup, so might be a platform-specific issue. Git version is the latest "Git for Windows", 1.9.5. This happens on every repository.

@tarsius tarsius modified the milestone: 2.1.0 Jul 2, 2015
@tarsius tarsius added the bug unconfirmed Maybe a bug, but unable to reproduce label Jul 2, 2015
@tarsius
Copy link
Member

tarsius commented Jul 2, 2015

I think it's more likely that this issue is limited to Emacs v24.4 than to MS Windows. But I don't have access to neither right now. Who can confirm this issue (while narrowing it down, I mean I trust the screenshot and all :-)?

@tarsius tarsius removed the bug unconfirmed Maybe a bug, but unable to reproduce label Jul 2, 2015
@npostavs
Copy link
Contributor

npostavs commented Jul 2, 2015

I see it on Emacs 24.4, 24.5, and an Emacs 25 snapshot (May 29) on Windows (I don't currently have access to a Linux machine).

@kyleam
Copy link
Member

kyleam commented Jul 2, 2015

I don't see it on Linux for 24.5.

@tarsius
Copy link
Member

tarsius commented Jul 2, 2015

Well, color me surprised. But of course I am happy I can stick the bug window label on this instead of just bug :-) (On the other hand that makes it harder to figure out what's going on).

@tarsius tarsius added the bug windows Something isn't working on Windows label Jul 2, 2015
@npostavs
Copy link
Contributor

npostavs commented Jul 4, 2015

The problem appears to be at the end of magit-log-refresh-buffer, the margin starts out correctly filled, but then

(defun magit-log-refresh-buffer (style revs args &optional files)
...
  (save-excursion
    (goto-char (point-min))
    (magit-format-log-margin))) ; <--- huh?

It goes to the beginning of the buffer and clears the margin. I don't understand how this works correctly on Linux. Is there supposed something else on the first line?

@tarsius tarsius closed this as completed in 1f98e2d Jul 4, 2015
@tarsius tarsius modified the milestones: 2.1.0, 2.2.0 Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug windows Something isn't working on Windows
Projects
None yet
Development

No branches or pull requests

4 participants