Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parens stripped from log messages #3

Closed
dabrahams opened this issue May 17, 2010 · 3 comments
Closed

Parens stripped from log messages #3

dabrahams opened this issue May 17, 2010 · 3 comments

Comments

@dabrahams
Copy link
Contributor

`l' gave me this line for one commit:

7a4d10dd * cosmetic Use Path for cleanliness

the actual commit comment is “(cosmetic) Use Path for cleanliness”
@vanicat
Copy link
Member

vanicat commented Feb 25, 2011

Test show that this seem to be solved. Could you confirm it ?

@lindi2
Copy link
Contributor

lindi2 commented Mar 2, 2011

Works for me in at least 862f364

@sigma
Copy link
Member

sigma commented Mar 27, 2011

this issue is stil present. But for it to show up, you need to have no ref/* point to the commit in question.
In this case, the list of beginning of the commit is wrongly interpreted as a reference list.

@sigma sigma closed this as completed Apr 4, 2011
pjweisberg added a commit that referenced this issue May 17, 2011
@pjweisberg
Fix bug deleting wrong remote branch
1c6f20e 
When attempting to delete a remote-tracking branch and the associated
remote branch with `k` in the branch manager, the code prior to this
change would:
1) Delete the branch at point.
2) Refresh the buffer as a side effect of calling Git.
3) Delete the remote branch referred to by the branch at point.

Of course, the branch at point in #3 is NOT the same branch that was
at point when the user pressed `k`.  I introduced this bug when I
taught the branch manager's buffer how to respond to magit-refresh.

To fix it, I capture the branch information in a variable before
making any changes, and use that variable instead of any *-at-point
functions.  I also don't change anything until after asking the user
if he wants to remove the remote branch as well, so the selected
branch is still visible when the question is asked.
@praet praet mentioned this issue Aug 8, 2013
Merged
@kenoyer130 kenoyer130 mentioned this issue Aug 13, 2014
Closed
@yyr yyr mentioned this issue Oct 28, 2014
Closed
@jmckitrick jmckitrick mentioned this issue May 3, 2015
Closed
@doublep doublep mentioned this issue May 13, 2015
Closed
kenny-thomas pushed a commit to kenny-thomas/magit that referenced this issue Aug 22, 2017
@rafl
Merge pull request magit#3 from petere/turn-off-save-place
b8cfcdf 
Turn off save-place in git-commit mode, if available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sigma @vanicat @dabrahams @lindi2