Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace-Mode isn’t compatible with Magit #3374

Closed
joncol opened this issue Feb 12, 2018 · 5 comments
Closed

Whitespace-Mode isn’t compatible with Magit #3374

joncol opened this issue Feb 12, 2018 · 5 comments

Comments

@joncol
Copy link

joncol commented Feb 12, 2018

After the latest update of Magit, when trying to run magit-status after enabling global-whitespace-mode I get the error message: user-error: Whitespace-Mode isn’t compatible with Magit. See magit-diff-paint-whitespace' for an alternative.`

This has not been a problem before.

Version info: Magit 20180211.700, Git 2.16.1, Emacs 26.0.90, gnu/linux

@tarsius
Copy link
Member

tarsius commented Feb 12, 2018

This has not been a problem before.

Nothing changed on Magit's side, but three people reported this over the last 24 hours. Do you use some starter-kit?

@tarsius
Copy link
Member

tarsius commented Feb 12, 2018

@joncol
Copy link
Author

joncol commented Feb 12, 2018

No starter kit used by me. I also tried starting using the output of magit-emacs-Q-command, then running global-whitespace-mode followed by magit-status, which caused the same error message to appear.

I'll check out the link you provided, thanks!

@joncol
Copy link
Author

joncol commented Feb 12, 2018

The first answer in the link provided seems to solve the problem for me. It's weird that this issue just started showing up, though. Anyway, do as you want with this issue, close it or leave it open.

Thanks for the good work on Magit!

@basil-conto
Copy link
Contributor

basil-conto commented Feb 12, 2018

FWIW, I committed the same fix as in the linked SE question to my dotfiles repo last week, so whatever caused the sudden change happened on or before 2018-02-02. I also periodically build Emacs from master, though, so I can't rule out the change being caused or exposed by something in Emacs proper, but the fact that there are multiple reports for this around the same time reduces the likelihood of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants