need easy way to review staged commits while committing

[aspiers]

After entering git-commit-mode via c c, there needs to be an easy way to view the staged commit's diffs in another buffer, so the diffs can be referred to whilst writing the log message. I'm assuming this requires integration with magit, which is why I didn't file it against the git-modes repo.

[tarsius]

There's an option for that: magit-expand-staged-on-commit. I haven't enabled that be default (yet?) because it would be slow when the diffs are huge.

[aspiers]

Sorry I wasn't clearer, but please re-open, because magit-expand-staged-on-commit isn't quite the functionality I was requesting. Your second sentence is a perfect example of why magit-expand-staged-on-commit isn't sufficient - sometimes the diffs are small, and sometimes they are huge. So the choice whether to view them should not be global, it should be per-commit. I don't want to see the diffs every time I commit - only when I press a key sequence from the commit buffer.

[tarsius]

Ah I see.

[tarsius]

I have just made the old commit mode available as a separate package. Until the new commit mode is functioning in all its glory, you might or might not want to use that.

The repository is a https://github.com/magit/magit-log-edit. It should also appear on Melpa soon.

[tarsius]

I have added magit-diff-staged and in git-commit-mode-map bound C-c C-d to that.

[aspiers]

Awesome thanks, I'll give it a try!

[tarsius]

I changed the binding to C-c C-d for consistency (but am considering making that and all pseudo header things available on C-c LETTER too).

[tarsius]

You are welcome.

[npostavs]

but am considering making that and all pseudo header things available on C-c LETTER too)

But isn't that supposed to be reserved for user bindings...

[tarsius]

I have some vague memory of that but though it was all of C-c and since we are violating that anyway, and every one else does it too... Are you sure that it is only C-c LETTER?

[dudebout]

It is only C-c LETTER and we do not violate it usually.

[tarsius]

Ah then. Well it's fixed already :-)

[npostavs]

C-c C-LETTER is for major mode
C-c LETTER is for user
See https://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html

But there are quite a few packages that use C-c LETTER anyway.

[aspiers]

But there are quite a few packages that use C-c LETTER anyway.

That doesn't make it ok for magit to do so :-)