Don't try to load magit-libgit when magit-inhibit-libgit is set #4967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context of this patch is that the app-emacs/magit package in Gentoo Linux no longer requires app-emacs/libegit2 as a dependency; see downstream bug: https://bugs.gentoo.org/910381
However, without libegit2, magit-libgit.el can neither be byte-compiled nor loaded (because it requires libgit). Therefore the Gentoo package in its default configuration no longer installs magit-libgit.
Unfortunately, this leads to a warning message when the libegit2 module is present (for unrelated reasons) on the user's system:
This patch suppresses that warning message by testing
magit-inhibit-libgit
before trying to load magit-libgit.