Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to load magit-libgit when magit-inhibit-libgit is set #4967

Merged
merged 1 commit into from Jul 23, 2023

Conversation

ulm
Copy link
Contributor

@ulm ulm commented Jul 20, 2023

The context of this patch is that the app-emacs/magit package in Gentoo Linux no longer requires app-emacs/libegit2 as a dependency; see downstream bug: https://bugs.gentoo.org/910381

However, without libegit2, magit-libgit.el can neither be byte-compiled nor loaded (because it requires libgit). Therefore the Gentoo package in its default configuration no longer installs magit-libgit.

Unfortunately, this leads to a warning message when the libegit2 module is present (for unrelated reasons) on the user's system:

Error while loading ‘magit-libgit’: (file-missing "Cannot open load file" "No such file or directory" "magit-libgit")
That is not fatal.  The ‘libegit2’ module just won’t be used.

This patch suppresses that warning message by testing magit-inhibit-libgit before trying to load magit-libgit.

@tarsius tarsius merged commit 38138c1 into magit:main Jul 23, 2023
24 checks passed
@tarsius
Copy link
Member

tarsius commented Jul 23, 2023

Thanks!

@ulm ulm deleted the inhibit-libgit branch July 23, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants