Check current buffer in magit-section-post-command-hook #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsius
force-pushed
the
check-current-buffer-in-post-command-hook
branch
from
3551711
to
6b10040
Compare
|
I think this might only affect the menu related steps. Please give my fixup commit a try. |
LemonBreezes
force-pushed
the
check-current-buffer-in-post-command-hook
branch
from
73a0ff2
to
7350f48
Compare
Yup, this works. Just force-pushed to fix a typo. |
The command may have used `set-window-buffer' to change the window's buffer without changing the current buffer. Previously that would have resulted in an error because `magit-section-post-command-hook' was not prepared to handle this situation, now we simply skip the menu related work in this case. Also see magit#5098.
tarsius
force-pushed
the
check-current-buffer-in-post-command-hook
branch
from
7350f48
to
039a180
Compare
|
I would like to investigate this some more1, but since I don't have the time for that now and this commit does the job, I am merging it. Thanks, by the way. I think I ran into this myself before, but couldn't [/didn't try to] figure out what was going on. Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where if you run a command like
persp-switchwhich usesset-window-buffer, the current buffer is not updated which can cause magit-post-command-hook to emit an error.