`magit-create-branch': simplify #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the `magit-create-branch-behaviour' option back in 2011 (commit 3cf5764), but made the horrible mistake of leaving the original behavior ("create branch at HEAD") the default. See e.g. this thread [1] from February 2013 on the ML. Instead of making 'at-point the default, let's just get rid of the option altogether and always try to find a rev at point first. Note that I'm intentionally *not* using `magit-default-rev', as that uses `magit-guess-branch', which is very likely to offer the *previous* value of HEAD instead of the current one. [1] mid:"87k3q9pm73.fsf@debian.org" Signed-off-by: Pieter Praet <pieter@praet.org>
tarsius
added a commit
that referenced
this pull request
Aug 30, 2013
`magit-create-branch': simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the `magit-create-branch-behaviour' option back in 2011
(commit 3cf5764), but made the horrible mistake of leaving the
original behavior ("create branch at HEAD") the default.
See e.g. this thread [1] from February 2013 on the ML.
Instead of making 'at-point the default, let's just get rid of
the option altogether and always try to find a rev at point first.
Note that I'm intentionally not using
magit-default-rev', as that usesmagit-guess-branch', which is very likely to offerthe previous value of HEAD instead of the current one.
[1] mid:"87k3q9pm73.fsf@debian.org"
Signed-off-by: Pieter Praet pieter@praet.org