[WIP] first draft to suggest requiring of extensions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $loadedExtensions = get_loaded_extensions(); | ||
|
|
||
| foreach ($loadedExtensions as $extensionName) { | ||
| $extensionSymbols = (new LocateDefinedSymbolsFromExtensions())->__invoke([$extensionName]); |
There was a problem hiding this comment.
You can create this function outside the loop.
maglnet
force-pushed
the
feature/suggest-extensions
branch
from
6b5275e
to
cc36627
Compare
maglnet
added a commit
that referenced
this pull request
Dec 16, 2015
suggest dependencies depending on loaded extensions
MidnightDesign
pushed a commit
to MidnightDesign/ComposerRequireChecker
that referenced
this pull request
Sep 17, 2020
Testing infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2, it would be nice to see, which dependency should be required to fix an unknown symbol.
This draft checks all loaded extensions for the unknown symbol and suggests requiring an extension if it can be found.