Skip to content

Commit

Permalink
fix(agw): Fixed CI dashboard reporting and cleanups for flaky retry s…
Browse files Browse the repository at this point in the history
…upport (#12375)

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
  • Loading branch information
VinashakAnkitAman committed Apr 5, 2022
1 parent fe659bf commit 672b981
Show file tree
Hide file tree
Showing 3 changed files with 189 additions and 113 deletions.
11 changes: 7 additions & 4 deletions ci-scripts/firebase_publish_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,13 @@ def lte_integ_test(args):
report = url_to_html_redirect(args.run_id, args.url)
# Possible args.verdict values are success, failure, or canceled
verdict = 'inconclusive'
if args.verdict.lower() == 'success':
verdict = 'pass'
elif args.verdict.lower() == 'failure':
verdict = 'fail'

# As per the recent change, CI process runs all integ tests ignoring the
# failing test cases, because of which CI report always shows lte integ
# test as success. Here we read the CI status from file for more accurate
# lte integ test execution status
with open('test_status.txt', 'r') as file:
verdict = file.read().rstrip()
publish_report('lte_integ_test', args.build_id, verdict, report)


Expand Down
3 changes: 2 additions & 1 deletion lte/gateway/python/integ_tests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $(PYTHON_BUILD)/setupinteg_env:
RESULTS_DIR := /var/tmp/test_results
define execute_test
echo "Running test: $(1)"
timeout --foreground -k 930s 900s sudo -E PATH=$(PATH) PYTHONPATH=$(PYTHONPATH):$(S1AP_TESTER_PYTHON_PATH) $(PYTHON_BUILD)/bin/nosetests --with-flaky --force-flaky --no-success-flaky-report --max-runs=1 --min-passes=1 --with-xunit --xunit-file=$(RESULTS_DIR)/$(basename $(notdir $(1))).xml -x -s $(1) || exit 1
timeout --foreground -k 930s 900s sudo -E PATH=$(PATH) PYTHONPATH=$(PYTHONPATH):$(S1AP_TESTER_PYTHON_PATH) $(PYTHON_BUILD)/bin/nosetests --with-flaky --force-flaky --no-success-flaky-report --max-runs=1 --min-passes=1 --with-xunit --xunit-file=$(RESULTS_DIR)/$(basename $(notdir $(1))).xml -x -s $(1) || (echo "fail" > $(MAGMA_ROOT)/test_status.txt && exit 1)
sleep 1
endef

Expand All @@ -45,6 +45,7 @@ integ_test: $(PYTHON_BUILD)/setupinteg_env $(BIN)/nosetests
ifdef TESTS
$(call execute_test,$(TESTS))
else
echo "pass" > $(MAGMA_ROOT)/test_status.txt
$(foreach test,$(EXTENDED_TESTS) $(PRECOMMIT_TESTS),$(call execute_test,$(test));)
endif

Expand Down

0 comments on commit 672b981

Please sign in to comment.