New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): Fixed CI dashboard reporting and cleanups for flaky retry support #12375
Merged
ardzoht
merged 2 commits into
magma:master
from
VinashakAnkitAman:ankit_fixed_ci_dashboard_reporting_and_cleanups_for_flaky_retry_support
Apr 5, 2022
Merged
fix(agw): Fixed CI dashboard reporting and cleanups for flaky retry support #12375
ardzoht
merged 2 commits into
magma:master
from
VinashakAnkitAman:ankit_fixed_ci_dashboard_reporting_and_cleanups_for_flaky_retry_support
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
pull-request-size
bot
added
the
size/L
Denotes a Pull Request that changes 100-499 lines.
label
Apr 1, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
Access gateway-related issue
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
labels
Apr 1, 2022
ardzoht
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
LGTM |
pruthvihebbani
approved these changes
Apr 4, 2022
tmdzk
approved these changes
Apr 5, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…upport (magma#12375) Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: agw
Access gateway-related issue
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
size/L
Denotes a Pull Request that changes 100-499 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(agw): Fixed CI dashboard reporting and cleanups for flaky retry support
Summary
The 2 recent PRs for adding cleanup for flaky retry support (#11774) and fixing ci dashboard reporting (#11975) were reverted as part of PRs #12107 and #12108 for bringing temporary stability to CI. The changes have been reverified over CI under branch integ_test_retries_test with PR #12357 and now ready to be merged again. Reference CI workflows:
https://github.com/magma/magma/runs/5775912937?check_suite_focus=true
Test plan
Verified with sanity and CI
Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com