Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Fixed CI dashboard reporting and cleanups for flaky retry support #12375

Conversation

VinashakAnkitAman
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman commented Apr 1, 2022

Title

fix(agw): Fixed CI dashboard reporting and cleanups for flaky retry support

Summary

The 2 recent PRs for adding cleanup for flaky retry support (#11774) and fixing ci dashboard reporting (#11975) were reverted as part of PRs #12107 and #12108 for bringing temporary stability to CI. The changes have been reverified over CI under branch integ_test_retries_test with PR #12357 and now ready to be merged again. Reference CI workflows:
https://github.com/magma/magma/runs/5775912937?check_suite_focus=true

Test plan

Verified with sanity and CI

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

…upport

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman requested a review from a team April 1, 2022 19:41
@VinashakAnkitAman VinashakAnkitAman requested a review from a team as a code owner April 1, 2022 19:41
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

feg-workflow

    2 files  202 suites   32s ⏱️
363 tests 363 ✔️ 0 💤 0
377 runs  377 ✔️ 0 💤 0

Results for commit afda8d1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

agw-workflow

     77 files     122 suites   7m 16s ⏱️
1 133 tests 1 124 ✔️ 9 💤 0
1 134 runs  1 125 ✔️ 9 💤 0

Results for commit afda8d1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pruthvihebbani
Copy link
Contributor

LGTM

@ardzoht ardzoht merged commit 672b981 into magma:master Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Unit Test Results

157 files  157 suites   2h 3m 4s ⏱️
307 tests 304 ✔️ 3 💤 0

Results for commit 672b981.

♻️ This comment has been updated with latest results.

emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…upport (magma#12375)

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants