Skip to content

Commit

Permalink
Make swagger fields optional (#512)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #512

Some swagger fields should be optional and marked as such

Reviewed By: tcirstea

Differential Revision: D16631735

fbshipit-source-id: 642a2e18bc03b915b53c97d063ff27ad38ffdb60
  • Loading branch information
Scott8440 authored and facebook-github-bot committed Aug 5, 2019
1 parent 26799ff commit 862d828
Show file tree
Hide file tree
Showing 5 changed files with 87 additions and 71 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 9 additions & 7 deletions orc8r/cloud/go/services/metricsd/swagger/swagger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,6 @@ definitions:
required:
- alert
- expr
- labels
- for
- annotations
properties:
alert:
type: string
Expand Down Expand Up @@ -484,8 +481,6 @@ definitions:
type: object
required:
- api_url
- channel
- username
properties:
api_url:
type: string
Expand All @@ -504,7 +499,6 @@ definitions:
- startsAt
- status
- updatedAt
- generatorURL
- labels
properties:
annotations:
Expand All @@ -514,7 +508,7 @@ definitions:
fingerprint:
type: string
receivers:
$ref: '#/definitions/alert_receiver_config'
$ref: '#/definitions/gettable_alert'
startsAt:
type: string
status:
Expand All @@ -526,6 +520,14 @@ definitions:
labels:
$ref: '#/definitions/prom_alert_labels'

gettable_alert:
type: object
required:
- name
properties:
name:
type: string

prom_alert_status:
type: object
required:
Expand Down

0 comments on commit 862d828

Please sign in to comment.