Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5G can't handle userLocationInformationNR timestamp field #12846

Closed
jrobsing opened this issue May 25, 2022 · 5 comments
Closed

5G can't handle userLocationInformationNR timestamp field #12846

jrobsing opened this issue May 25, 2022 · 5 comments
Labels
type: bug Something isn't working wontfix This will not be worked on

Comments

@jrobsing
Copy link

Your Environment

  • Version: 1.7
  • Affected Component: AGW
  • Affected Subcomponent: mme
  • Deployment Environment: bare metal

Describe the Issue

Tested the AGW against UERANSIM v3.2.6. The InitialUEMessage fails. The mme log says "tasks/ngap/ngap_amf_decoder.c:0043 Failed to decode PDU". There was no reply message from the AGW. The timestamp field is optional per ts 38.413 UserLocationInformationNR section 9.4.5.

To Reproduce

  1. Install UERANSIM v3.2.6
  2. Modify the UERANSIM config/custom-gnb.yaml file to match the AGW settings
  3. Run "./nr_gnb -c ../config/custom-gnb.yaml"
  4. Modify the UERANSIM config/custom-ue.yaml file to match the AGW settings
  5. Run "./nr_ue -c ../config/custom-ue.yaml"

Expected behavior
The UERANSIM UE should register, get an IP, and be able to pass traffic. Although I modified UERANSIM to get my test to work (see below), I believe the actual bug is in the amf because it should have accepted the timestamp field.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I was able to modify UERANSIM to make it work, by commenting out the timestamp field in file UERANSIM/src/gnb/ngap/transport.cpp function NgapTask::sendNgapUeAssociated. See below. The two commented out lines below are the changes.

        asn::ngap::AddProtocolIeIfUsable(
            *pdu, asn_DEF_ASN_NGAP_UserLocationInformation, ASN_NGAP_ProtocolIE_ID_id_UserLocationInformation,
            FindCriticalityOfUserIe(pdu, ASN_NGAP_ProtocolIE_ID_id_UserLocationInformation), [this](void *mem) {
                auto *loc = reinterpret_cast<ASN_NGAP_UserLocationInformation *>(mem);
                loc->present = ASN_NGAP_UserLocationInformation_PR_userLocationInformationNR;
                loc->choice.userLocationInformationNR = asn::New<ASN_NGAP_UserLocationInformationNR>();

                auto &nr = loc->choice.userLocationInformationNR;
//                nr->timeStamp = asn::New<ASN_NGAP_TimeStamp_t>();

                ngap_utils::ToPlmnAsn_Ref(m_base->config->plmn, nr->nR_CGI.pLMNIdentity);
                asn::SetBitStringLong<36>(m_base->config->nci, nr->nR_CGI.nRCellIdentity);
                ngap_utils::ToPlmnAsn_Ref(m_base->config->plmn, nr->tAI.pLMNIdentity);
                asn::SetOctetString3(nr->tAI.tAC, octet3{m_base->config->tac});
//                asn::SetOctetString4(*nr->timeStamp, octet4{utils::CurrentTimeStamp().seconds32()});
            });
@jrobsing jrobsing added the type: bug Something isn't working label May 25, 2022
@jrobsing
Copy link
Author

This is the packet dissection of the failing case.

eth1.txt

@stale
Copy link

stale bot commented Aug 30, 2022

This issue or pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs in the next 14 days.

@stale stale bot added the wontfix This will not be worked on label Aug 30, 2022
@stale
Copy link

stale bot commented Sep 13, 2022

This issue or pull request has exceeded its lifecylce and was automatically closed. Should you wish to continue working on this, please reopen it.

@stale
Copy link

stale bot commented Sep 28, 2022

This issue or pull request has exceeded its lifecylce and was automatically closed. Should you wish to continue working on this, please reopen it.

@stale stale bot closed this as completed Sep 28, 2022
jordanvrtanoski added a commit to jordanvrtanoski/magma that referenced this issue Oct 14, 2022
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed on the fix.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
jordanvrtanoski added a commit to jordanvrtanoski/magma that referenced this issue Oct 14, 2022
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
jordanvrtanoski added a commit to jordanvrtanoski/magma that referenced this issue Oct 14, 2022
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
@jao-tm
Copy link

jao-tm commented Dec 19, 2022

Has this been added to AGW v1.8? I am still getting the same error

jordanvrtanoski added a commit to jordanvrtanoski/magma that referenced this issue Feb 8, 2023
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
jordanvrtanoski added a commit to jordanvrtanoski/magma that referenced this issue Feb 13, 2023
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
jordanvrtanoski added a commit to jordanvrtanoski/magma that referenced this issue Mar 15, 2024
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
brunohcfaria pushed a commit to brunohcfaria/magma that referenced this issue May 14, 2024
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
brunohcfaria pushed a commit to brunohcfaria/magma that referenced this issue Aug 2, 2024
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
brunohcfaria pushed a commit to brunohcfaria/magma that referenced this issue Aug 2, 2024
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
brunohcfaria pushed a commit to brunohcfaria/magma that referenced this issue Aug 13, 2024
…12846

The issue reported with magma#12846 is caused by the missaligment of the
NGAP R16 ASN.1 file used to generate the NGAP message library with the
published standard. The file was previously modified to avoid an error
that the asn1 compiler was throwing for the missing external reference.

The fix is returning the NGAP R16 ASN.1 to the published standard and
is dereferencing the `ProtocolIE-SingleContainer` to avoid the compiler
error (untill the compiler issue is addressed).

All sanity test had passed.

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants