fix(amf): AMF is accepting the PDU Session when a PDU Request with DNN as empty string is been received from UE. #10500
Conversation
|
Thanks for opening a PR! 💯 A couple initial guidelines
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
| @@ -593,7 +595,7 @@ M5GSmCause amf_smf_get_smcause(amf_ue_ngap_id_t ue_id, ULNASTransportMsg* msg) { | |||
| the external DNN because the DNN was not included | |||
| although required or if the DNN could not be resolved. | |||
| */ | |||
| if (msg->dnn.len == 0 && | |||
| if (msg->dnn.len <= 1 && | |||
There was a problem hiding this comment.
what is the reason for this change? should not this be instead msg->dnn.len == 0 || (ue_context->amf_context.apn_config_profile.nb_apns == 0)
There was a problem hiding this comment.
msg->dnn.len is the length of dnn contents. DNN value will have the first byte that tells the DNN length and then DNN value. In this case msg->dnn.len is 1 means no DNN content. Minimum value should be more than 1.
should not this be instead msg->dnn.len == 0 || (ue_context->amf_context.apn_config_profile.nb_apns == 0)
If UE sends empty DNN or DNN IE not present. As per PR #9645 default DNN is picking from apn_config_profile.
There was a problem hiding this comment.
what about the AND vs OR statement here. Should not it be OR? If there is no apn profile for UE, it should be rejected.
There was a problem hiding this comment.
If there is no apn profile for UE and UE sends DNN. As per PR #9645 PDU session will be rejected with cause 91: DNN not supported or not subscribed.
There was a problem hiding this comment.
@ulaskozat these are the cases we are handling and their current behavior. Please review it and provide the feedback.
Above the case is for the Cause 27, #9645 PR handling other scenarios.
There was a problem hiding this comment.
@sreedharkumartn where is cause #91 implemented?
sreedharkumartn
added
ready2merge
…N as empty string is been received from UE. Signed-off-by: sreedharkumartn <sreedhar.kumar@wavelabs.ai>
sreedharkumartn
force-pushed
the
topic/sreedhar/missing_dnn
branch
from
f1ffe09
to
e65cdef
Compare
Signed-off-by: sreedharkumartn sreedhar.kumar@wavelabs.ai
Summary
Issues handled:
Test Plan
Fix for Issue 1.
Subscriber dnn(apn) info:
UERANSIM dnn(apn) info:
Pcap Snap:
Log:
mme_cause_1_resolved_23nov.log
Fix for Issue 2.
Pcap Snap:
Log:
mme_cause_2_resolved_23nov.log
UT cases Validated:
Checked Normal Registration accept, PDU session establishment request and PDU session establishment release with UERANSIM
Pcap Snap:
Log:
mme_23nov.log
Additional Information