Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amf): PDU-Reject message is not proper for UnsupportedDNN cause s… #12488

Merged
merged 1 commit into from Apr 26, 2022

Conversation

Rajeshs23
Copy link
Contributor

@Rajeshs23 Rajeshs23 commented Apr 18, 2022

PDU-Reject message is not proper for Unsupported DNN cause sent from AMF

Signed-off-by: Rajeshs23 rajesh.sure@wavelabs.ai

Summary

Issues Handled:
AMF is sending PDU-Request for PDU-Reject Unsupported DNN .AMF should sent PDU-Reject ,
instead of PDU-Request.
Changes are made, unit test case is written for missing_dnn(test_pdu_unknown_dnn_missing_dnn) and test cases are passing .
tested Using UERANSIM and seen amf sending PDU session reject message.
missing_dnn_test_case

Test Plan

-Tested using UERANSIM
-Unit testing

Additional Information

rejectcaue=se
These are the cases handling. Above the case is for the Cause 27.
corresponding zenhub taskid #12478

pdusessionreject

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Apr 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2022

feg-workflow

    2 files  202 suites   39s ⏱️
370 tests 370 ✔️ 0 💤 0
384 runs  384 ✔️ 0 💤 0

Results for commit c3f90a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2022

agw-workflow

     78 files     123 suites   7m 54s ⏱️
1 158 tests 1 148 ✔️ 9 💤   1
1 160 runs  1 140 ✔️ 9 💤 11

For more details on these failures, see this check.

Results for commit c3f90a5.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Apr 19, 2022
@Sathyaj27 Sathyaj27 marked this pull request as ready for review April 20, 2022 04:31
@Sathyaj27 Sathyaj27 requested review from a team and ardzoht April 20, 2022 04:31
@ganeshg87
Copy link
Contributor

@Rajeshs23 ,
Please describe the Error scenario and current behavior
and refer below PR which is related to this and map your use case
#10500

@Rajeshs23
Copy link
Contributor Author

@Rajeshs23 , Please describe the Error scenario and current behavior and refer below PR which is related to this and map your use case #10500

Hi @ganeshg87 comments are addressed. Please verify once.

Copy link
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Apr 25, 2022
…ent from AMF

Signed-off-by: Rajeshs23 <rajesh.sure@wavelabs.ai>
@pruthvihebbani pruthvihebbani merged commit 0dd36e7 into magma:master Apr 26, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…ent from AMF (magma#12488)

Signed-off-by: Rajeshs23 <rajesh.sure@wavelabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue priority: medium Medium priority bug product: 5g sa ready2merge This PR is ready to be merged (is approved and passes all required checks) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDU-Reject message is not proper for UnsupportedDNN cause sent from AMF
4 participants