Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add wrapper Make commands to run Bazel #10642

Merged
merged 1 commit into from
Dec 8, 2021
Merged

feat: Add wrapper Make commands to run Bazel #10642

merged 1 commit into from
Dec 8, 2021

Conversation

themarwhal
Copy link
Member

@themarwhal themarwhal commented Dec 2, 2021 •
edited

Signed-off-by: Marie Bremner marwhal@fb.com

Summary

  1. Add 2 Makefile commands build_c and test_c to wrap some configs needed to run tests and build debug/relwithdebinfo builds
  2. Does NOT affect existing build
  3. Moved all the clang related commands to the bottom

Related

PR to add LSAN configurations: #10583

Test Plan

ran both commands locally

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021 •
edited

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021 •
edited

feg-workflow

    2 files  199 suites   32s ⏱️
350 tests 350 ✔️ 0 💤 0 ❌
364 runs  364 ✔️ 0 💤 0 ❌

Results for commit e8a060a.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 2, 2021
@themarwhal themarwhal changed the title add bazel commands feat: Add wrapper Make commands to run Bazel Dec 2, 2021
@themarwhal themarwhal marked this pull request as ready for review December 2, 2021 18:23
@themarwhal themarwhal requested a review from a team as a code owner December 2, 2021 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021 •
edited

agw-workflow

    2 files      2 suites   3m 35s ⏱️
508 tests 499 ✔️ 9 💤 0 ❌
509 runs  500 ✔️ 9 💤 0 ❌

Results for commit e8a060a.

♻️ This comment has been updated with latest results.

@themarwhal themarwhal mentioned this pull request Dec 2, 2021
Closed
1 task
@themarwhal themarwhal marked this pull request as draft December 3, 2021 00:34
@themarwhal themarwhal removed the request for review from pshelar December 3, 2021 00:34
@themarwhal themarwhal marked this pull request as ready for review December 3, 2021 00:34
@themarwhal themarwhal marked this pull request as draft December 3, 2021 00:35
@themarwhal themarwhal marked this pull request as ready for review December 3, 2021 00:35
@themarwhal themarwhal requested review from ardzoht and pshelar and removed request for ardzoht December 3, 2021 00:36
@themarwhal themarwhal force-pushed the add-bazel-commands branch 3 times, most recently from 012c74d to b3db877 Compare December 3, 2021 18:00
@themarwhal themarwhal enabled auto-merge (squash) December 3, 2021 21:51
@themarwhal themarwhal enabled auto-merge (squash) December 4, 2021 13:26
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 8, 2021
@themarwhal
feat: add Makefile wrapper commands for building with Bazel
e8a060a 
Signed-off-by: Marie Bremner <marwhal@fb.com>
@themarwhal themarwhal merged commit d22b707 into magma:master Dec 8, 2021
@themarwhal themarwhal deleted the add-bazel-commands branch December 8, 2021 23:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021 •
edited

Unit Test Results

    1 files      1 suites   7m 14s ⏱️
149 tests 148 ✔️ 1 💤 0 ❌

Results for commit d22b707.

♻️ This comment has been updated with latest results.

@themarwhal themarwhal added the bazel changes for the Bazelification effort label Jan 11, 2022
@LKreutzer LKreutzer mentioned this pull request Jul 5, 2022
Merged
1 task
This was referenced Aug 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koolzz koolzz koolzz approved these changes

@pshelar pshelar Awaiting requested review from pshelar

Assignees
No one assigned
Labels
bazel changes for the Bazelification effort component: agw Access gateway-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@themarwhal @koolzz