chore: remove experimental_strict_action_env option from bazelrc

[LKreutzer]

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

• The bazel option --experimental_strict_action_env is removed from the .bazelrc
• This option was introduced in feat: Add wrapper Make commands to run Bazel #10642 to wrap some bazel commands in Make targets
  • The Make targets do not seem to be used in CI but may be convenient for local development

Test Plan

• CI
• Run the Make targets build_c, test_c and build_oai_clang.
  • The Make calls need to happen in magma/lte/gateway, however there is currently a bug (see issue Bazel commands only work in the magma directory #13102) which requires a slight modification of the .bazelrc for testing.
  • The line import bazel/bazelrcs/cache.bazelrc needs to be replaced by import /home/vagrant/magma/bazel/bazelrcs/cache.bazelrc for testing inside the magma-vm.
  • Builds are successful and no change in behaviour is observed compared to the run with the flag.

Additional Information

• The initial run of the bazel workflow is very slow on this PR because the removal of the flag prevents most cache hits. Once the cache is filled on master the build time should be unaffected.

  • I filled the cache from the fork and now the workflow has a normal runtime.

• The option has been renamed to incompatible_strict_action_env (see --incompatible_strict_action_env bazelbuild/bazel#6648)

• The option has the following description in the current docs:
  

  • Since we have a relatively reproducible build environment in CI it should not affect the cache hits once they are generated without this flag.
  • ⚠️ It might be good to monitor the remote cache hits in the weeks following a potential merge of this PR.

• We specify build:asan --action_env=ASAN_OPTIONS=detect_leaks=1:color=always in the current .bazelrc

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

agw-workflow

580 tests   576 ✔️  3m 48s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 7ac3332.

[nstng]

LGTM - discussed offline