feat: Add cli for simple gateway registration #11195

christinewang5 · 2022-01-18T15:36:06Z

Summary

register CLI for gateways

Testing

manually tested by running CLIs

Note: this PR is dependent on #11169 & #11692

github-actions · 2022-01-18T15:36:23Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-01-18T15:37:30Z

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

github-actions · 2022-01-18T15:38:18Z

Oops! Looks like you failed the Python Format Check.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

github-actions · 2022-01-18T15:55:00Z

feg-workflow

    2 files 202 suites 34s ⏱️
363 tests 363 ✔️ 0 💤 0 ❌
377 runs 377 ✔️ 0 💤 0 ❌

Results for commit b0f7101.

♻️ This comment has been updated with latest results.

github-actions · 2022-01-18T16:21:42Z

cloud-workflow

    7 files 351 suites 2m 1s ⏱️
960 tests 960 ✔️ 0 💤 0 ❌

Results for commit b0f7101.

♻️ This comment has been updated with latest results.

github-actions · 2022-01-18T16:35:49Z

agw-workflow

  28 files   43 suites 4m 23s ⏱️
738 tests 729 ✔️ 9 💤 0 ❌
739 runs 730 ✔️ 9 💤 0 ❌

Results for commit b0f7101.

♻️ This comment has been updated with latest results.

github-actions · 2022-02-15T21:48:58Z

nms-workflow

0 files 0 suites 0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit cc58f43.

orc8r/gateway/python/scripts/register.py

orc8r/gateway/python/magma/common/service_registry.py

ardzoht

lgtm

hcgatewood

Looking good! Couple small things

orc8r/gateway/python/magma/common/service_registry.py

hcgatewood · 2022-03-08T17:44:00Z

orc8r/gateway/python/magma/common/service_registry.py

+        Returns:
+            grpc channel
+        """
+        rootca_path = ROOTCA_PATH if not rootca_path else rootca_path


So if no rootca path is passed in, we want to use the default system credentials. I think that means you don't have to pass any ssl creds, but not sure how it works. But if you want, we can leave it like this for now, and I'll test it when I get around to making the Orc8r<>Let'sEncrypt work e2e

orc8r/gateway/python/scripts/register.py

hcgatewood

Lgtm!

hcgatewood · 2022-03-15T22:55:18Z

orc8r/gateway/python/scripts/register.py

+    if res.HasField("error"):
+        raise Exception(res.error)
+
+    msg = textwrap.dedent(


Nit: I'd prob put this printed msg in the main func, to keep this func as "stateless" as possible

hcgatewood · 2022-03-15T22:55:49Z

orc8r/gateway/python/scripts/register.py

+if __name__ == "__main__":
+    main()
+    print("> Running checkin_cli")
+    checkin_cli.main()


Oh dang does this work? Nice good to know

Yeah looks a bit sketch but it does 🤷🏻‍♀️

Signed-off-by: Christine Wang <christinewang@fb.com>

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 18, 2022

github-actions bot added component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels Jan 18, 2022

christinewang5 changed the title ~~Register gateway script~~ feat: Add cli for simple gateway registration Jan 18, 2022

christinewang5 force-pushed the register-gateway-script branch from 86b10e3 to 18a5a5d Compare January 18, 2022 15:40

christinewang5 force-pushed the register-gateway-script branch from 18a5a5d to b61322e Compare February 4, 2022 17:38

pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Feb 4, 2022

github-actions bot removed the component: cwf label Feb 4, 2022

christinewang5 force-pushed the register-gateway-script branch 3 times, most recently from 0dc08d2 to 8403f87 Compare February 4, 2022 19:12

christinewang5 force-pushed the register-gateway-script branch 2 times, most recently from f2158bd to 9fb1e1d Compare February 15, 2022 20:13

github-actions bot removed the component: feg FEG-gateway related issues label Feb 15, 2022

christinewang5 force-pushed the register-gateway-script branch from 9fb1e1d to cc58f43 Compare February 15, 2022 21:32

github-actions bot added the component: nms NMS-related issue label Feb 15, 2022

christinewang5 force-pushed the register-gateway-script branch from cc58f43 to ecca9f9 Compare February 22, 2022 16:28

github-actions bot removed the component: nms NMS-related issue label Feb 22, 2022

christinewang5 force-pushed the register-gateway-script branch 2 times, most recently from 1a1f771 to c0b4922 Compare February 22, 2022 18:11

christinewang5 marked this pull request as ready for review February 22, 2022 18:11

christinewang5 force-pushed the register-gateway-script branch from 08fe066 to 91b5f74 Compare February 24, 2022 05:49

christinewang5 commented Feb 24, 2022

View reviewed changes

orc8r/gateway/python/scripts/register.py Outdated Show resolved Hide resolved

christinewang5 force-pushed the register-gateway-script branch from 91b5f74 to b87f344 Compare February 24, 2022 05:54

christinewang5 requested review from hcgatewood and ardzoht February 24, 2022 14:52

christinewang5 force-pushed the register-gateway-script branch 3 times, most recently from af8a169 to 02a07dd Compare March 3, 2022 05:58

ardzoht reviewed Mar 3, 2022

View reviewed changes

orc8r/gateway/python/magma/common/service_registry.py Outdated Show resolved Hide resolved

orc8r/gateway/python/magma/common/service_registry.py Show resolved Hide resolved

themarwhal removed their request for review March 4, 2022 15:23

christinewang5 force-pushed the register-gateway-script branch from 02a07dd to 3fee3c3 Compare March 8, 2022 15:34

christinewang5 requested a review from ardzoht March 8, 2022 15:34

christinewang5 force-pushed the register-gateway-script branch from 3fee3c3 to 5b3393e Compare March 8, 2022 16:02

ardzoht approved these changes Mar 8, 2022

View reviewed changes

hcgatewood suggested changes Mar 8, 2022

View reviewed changes

christinewang5 force-pushed the register-gateway-script branch 4 times, most recently from 8a5cacb to b0f7101 Compare March 9, 2022 16:35

christinewang5 requested a review from hcgatewood March 9, 2022 16:35

hcgatewood approved these changes Mar 15, 2022

View reviewed changes

christinewang5 force-pushed the register-gateway-script branch from b0f7101 to b91d25b Compare March 16, 2022 16:15

hcgatewood enabled auto-merge (squash) March 17, 2022 20:36

christinewang5 force-pushed the register-gateway-script branch 2 times, most recently from 813b111 to 34c74be Compare March 21, 2022 17:37

feat: Add cli for simple gateway registration

6ff4ea8

Signed-off-by: Christine Wang <christinewang@fb.com>

christinewang5 force-pushed the register-gateway-script branch from 34c74be to 6ff4ea8 Compare March 21, 2022 19:19

hcgatewood merged commit f09f3fe into magma:master Mar 21, 2022

ardzoht pushed a commit that referenced this pull request Mar 30, 2022

feat: Add cli for simple gateway registration (#11195)

d6fdf24

emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022

feat: Add cli for simple gateway registration (magma#11195)

d206163

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add cli for simple gateway registration #11195

feat: Add cli for simple gateway registration #11195

christinewang5 commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Feb 15, 2022

ardzoht left a comment

hcgatewood left a comment

hcgatewood Mar 8, 2022

hcgatewood left a comment

hcgatewood Mar 15, 2022

hcgatewood Mar 15, 2022

christinewang5 Mar 16, 2022

feat: Add cli for simple gateway registration #11195

feat: Add cli for simple gateway registration #11195

Conversation

christinewang5 commented Jan 18, 2022 • edited

Summary

Testing

github-actions bot commented Jan 18, 2022

Howto

More info

github-actions bot commented Jan 18, 2022 • edited

Howto

github-actions bot commented Jan 18, 2022 • edited

Howto

github-actions bot commented Jan 18, 2022 • edited

feg-workflow

github-actions bot commented Jan 18, 2022 • edited

cloud-workflow

github-actions bot commented Jan 18, 2022 • edited

agw-workflow

github-actions bot commented Feb 15, 2022

nms-workflow

ardzoht left a comment

Choose a reason for hiding this comment

hcgatewood left a comment

Choose a reason for hiding this comment

hcgatewood Mar 8, 2022

Choose a reason for hiding this comment

hcgatewood left a comment

Choose a reason for hiding this comment

hcgatewood Mar 15, 2022

Choose a reason for hiding this comment

hcgatewood Mar 15, 2022

Choose a reason for hiding this comment

christinewang5 Mar 16, 2022

Choose a reason for hiding this comment

christinewang5 commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited

github-actions bot commented Jan 18, 2022 •

edited