Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(orc8r): Fixed control proxy not being set in the tenant service #11692

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix(orc8r): Fixed control proxy not being set in the tenant service #11692

merged 1 commit into from
Feb 23, 2022

Conversation

christinewang5
Copy link
Contributor

wasn't being set correctly before

tested by running orc8r locally
image

@christinewang5 christinewang5 requested review from a team and hcgatewood February 18, 2022 20:27
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Feb 18, 2022
@christinewang5 christinewang5 force-pushed the tenant-control-proxy branch 2 times, most recently from 008a46d to 5a0c1a0 Compare February 18, 2022 20:28
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022 •
edited

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022 •
edited

feg-workflow

    2 files  202 suites   33s ⏱️
363 tests 363 ✔️ 0 💤 0 ❌
377 runs  377 ✔️ 0 💤 0 ❌

Results for commit 98c0460.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022 •
edited

cloud-workflow

    8 files  371 suites   2m 42s ⏱️
967 tests 967 ✔️ 0 💤 0 ❌

Results for commit 98c0460.

♻️ This comment has been updated with latest results.

@christinewang5
fix(orc8r): Fixed control proxy not being set in the tenant service
98c0460 
Signed-off-by: Christine Wang <christinewang@fb.com>
@github-actions
Copy link
Contributor

agw-workflow

    2 files      2 suites   4m 6s ⏱️
561 tests 552 ✔️ 9 💤 0 ❌
562 runs  553 ✔️ 9 💤 0 ❌

Results for commit 98c0460.

@christinewang5 christinewang5 mentioned this pull request Feb 22, 2022
Merged
@hcgatewood hcgatewood merged commit ac85aa6 into magma:master Feb 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022 •
edited

Unit Test Results

  25 files    25 suites   19m 59s ⏱️
175 tests 171 ✔️ 3 💤 1 ❌

For more details on these failures, see this check.

Results for commit ac85aa6.

♻️ This comment has been updated with latest results.

emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@christinewang5 @emakeev
fix(orc8r): Fixed control proxy not being set in the tenant service (m…
0e651c7 
…agma#11692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcgatewood hcgatewood hcgatewood approved these changes

@themarwhal themarwhal themarwhal approved these changes

Assignees
No one assigned
Labels
component: orc8r Orchestrator-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christinewang5 @hcgatewood @themarwhal