fix(amf): Re-Attempt Authentication during subscriberdb lock #11454

RahulKalsangra · 2022-02-08T07:58:34Z

Signed-off-by: RahulKalsangra rahul.kalsangra@wavelabs.ai

Summary

AMF should re-attempt authentication when subscriberdb returns Server too busy message

Fix

Added configurable parameter for re-trying the authentication during lock
Introduced a new function amf_authentication_request_sent which can be called from
regular and re-attempted authentication
After configurable attempts authentication is rejected.

Test Plan

Added new UT case : TestAuthFailureFromSubscribeDbLock

Tested on ueransim with help of # 11438

Additional Information

This change is backwards-breaking

github-actions · 2022-02-08T07:58:51Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-02-08T08:07:19Z

feg-workflow

    2 files 202 suites 32s ⏱️
362 tests 362 ✔️ 0 💤 0 ❌
376 runs 376 ✔️ 0 💤 0 ❌

Results for commit ac46c8f.

♻️ This comment has been updated with latest results.

github-actions · 2022-02-08T08:58:36Z

agw-workflow

  60 files   87 suites 4m 47s ⏱️
970 tests 961 ✔️ 9 💤 0 ❌
971 runs 962 ✔️ 9 💤 0 ❌

Results for commit ac46c8f.

♻️ This comment has been updated with latest results.

lte/gateway/c/core/oai/tasks/amf/nas_proc.cpp

lte/gateway/c/core/oai/tasks/amf/amf_authentication.cpp

github-actions · 2022-02-14T14:33:46Z

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

github-actions · 2022-02-16T17:24:20Z

Oops! Looks like you failed the Python Format Check.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

sebathomas · 2022-02-17T08:58:14Z

You can run ./precommit.py --format --diff in lte/gateway/python to fix the Python formatting errors.

lte/gateway/c/core/oai/tasks/amf/amf_authentication.cpp

lte/gateway/c/core/oai/tasks/amf/amf_authentication.h

sebathomas

Thanks for making the changes, Python code looks good to me. 👍

ardzoht

lgtm

sebathomas · 2022-03-17T08:01:15Z

I think the semantic PR check does not know "amf". This will probably be ready to merge if you rename it to "fix(mme)" or "fix(agw)".

sebathomas · 2022-03-17T09:45:17Z

Sorry, I may have been wrong about that. Seems the semantic PR check is broken in general at the moment, see:
#12172

RahulKalsangra · 2022-03-17T10:09:59Z

Sorry, I may have been wrong about that. Seems the semantic PR check is broken in general at the moment, see: #12172

thanks for the information.

sebathomas · 2022-03-17T13:18:47Z

I think the problem is fixed now, you just have to rebase on the current master.

… during authentication Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

…1454) * fix(amf): handle and proper response the error code from subscriberdb during authentication Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai> * Addressed review comment (R1) Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai> * Addressed review comment (R2) Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

* fix(amf): handle and proper response the error code from subscriberdb during authentication Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai> * Addressed review comment (R1) Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai> * Addressed review comment (R2) Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

…1454) Signed-off-by: sreedharkumartn <sreedhar.kumar@wavelabs.ai>

…1454) * fix(amf): handle and proper response the error code from subscriberdb during authentication Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai> * Addressed review comment (R1) Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai> * Addressed review comment (R2) Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Feb 8, 2022

github-actions bot added the component: agw Access gateway-related issue label Feb 8, 2022

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from fb0d54c to 1f3b25d Compare February 8, 2022 08:09

RahulKalsangra requested a review from panyogesh February 8, 2022 08:42

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from 1f3b25d to 45e464c Compare February 8, 2022 10:51

moinuddin1980 reviewed Feb 8, 2022

View reviewed changes

lte/gateway/c/core/oai/tasks/amf/nas_proc.cpp Outdated Show resolved Hide resolved

moinuddin1980 reviewed Feb 8, 2022

View reviewed changes

lte/gateway/c/core/oai/tasks/amf/nas_proc.cpp Outdated Show resolved Hide resolved

moinuddin1980 reviewed Feb 8, 2022

View reviewed changes

lte/gateway/c/core/oai/tasks/amf/amf_authentication.cpp Outdated Show resolved Hide resolved

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch 4 times, most recently from 9e07ed1 to d592bd4 Compare February 14, 2022 14:27

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch 2 times, most recently from d592bd4 to 05ebfdc Compare February 16, 2022 17:21

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from 05ebfdc to d89f6aa Compare February 16, 2022 17:32

RahulKalsangra marked this pull request as ready for review February 17, 2022 04:39

RahulKalsangra requested review from a team February 17, 2022 04:39

RahulKalsangra requested a review from a team as a code owner February 17, 2022 04:39

RahulKalsangra requested a review from ardzoht February 17, 2022 04:39

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from d89f6aa to 469227b Compare February 21, 2022 06:51

panyogesh reviewed Feb 21, 2022

View reviewed changes

lte/gateway/c/core/oai/tasks/amf/amf_authentication.cpp Outdated Show resolved Hide resolved

lte/gateway/c/core/oai/tasks/amf/amf_authentication.h Outdated Show resolved Hide resolved

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from 469227b to db7f562 Compare February 22, 2022 11:05

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from db7f562 to 0ee2500 Compare March 2, 2022 09:09

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch 2 times, most recently from 17ab7d0 to 1b098d0 Compare March 16, 2022 16:18

sebathomas approved these changes Mar 16, 2022

View reviewed changes

RahulKalsangra requested a review from pruthvihebbani March 16, 2022 16:37

ardzoht approved these changes Mar 16, 2022

View reviewed changes

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from 1b098d0 to b4bd50c Compare March 17, 2022 04:00

pruthvihebbani approved these changes Mar 17, 2022

View reviewed changes

RahulKalsangra added ready2merge This PR is ready to be merged (is approved and passes all required checks) product: 5g sa labels Mar 17, 2022

RahulKalsangra removed the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Mar 17, 2022

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from b4bd50c to ac0cab8 Compare March 17, 2022 14:34

RahulKalsangra added 3 commits March 17, 2022 21:06

fix(amf): handle and proper response the error code from subscriberdb…

9c43a8c

… during authentication Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

Addressed review comment (R1)

0eadd75

Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

Addressed review comment (R2)

cfe23f2

Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>

RahulKalsangra force-pushed the RahulKalsangra/tpc/authenticationprocedure branch from ac0cab8 to cfe23f2 Compare March 17, 2022 15:52

RahulKalsangra added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Mar 17, 2022

sebathomas merged commit 767eaab into magma:master Mar 18, 2022

RahulKalsangra mentioned this pull request Mar 22, 2022

[Regression]Subscriber-db is getting locked very frequently and AMF is not sending any response to UE #11088

Closed

RahulKalsangra deleted the RahulKalsangra/tpc/authenticationprocedure branch March 25, 2022 06:27

RahulKalsangra restored the RahulKalsangra/tpc/authenticationprocedure branch March 25, 2022 06:29

sreedharkumartn added a commit to sreedharkumartn/magma that referenced this pull request Apr 12, 2022

fix(amf): Re-Attempt Authentication during subscriberdb lock (magma#1…

f8736f9

…1454) Signed-off-by: sreedharkumartn <sreedhar.kumar@wavelabs.ai>

panyogesh mentioned this pull request Apr 12, 2022

[AMF]: Configuration validation on 1.7.1 #12442

Closed

panyogesh added the backport-v1.7 MME fixes to be backported for 1.7 label Apr 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(amf): Re-Attempt Authentication during subscriberdb lock #11454

fix(amf): Re-Attempt Authentication during subscriberdb lock #11454

RahulKalsangra commented Feb 8, 2022 •

edited by panyogesh

github-actions bot commented Feb 8, 2022

github-actions bot commented Feb 8, 2022 •

edited

github-actions bot commented Feb 8, 2022 •

edited

github-actions bot commented Feb 14, 2022 •

edited

github-actions bot commented Feb 16, 2022 •

edited

sebathomas commented Feb 17, 2022

sebathomas left a comment

ardzoht left a comment

sebathomas commented Mar 17, 2022 •

edited

sebathomas commented Mar 17, 2022

RahulKalsangra commented Mar 17, 2022

sebathomas commented Mar 17, 2022

fix(amf): Re-Attempt Authentication during subscriberdb lock #11454

fix(amf): Re-Attempt Authentication during subscriberdb lock #11454

Conversation

RahulKalsangra commented Feb 8, 2022 • edited by panyogesh

Summary

Fix

Test Plan

Additional Information

github-actions bot commented Feb 8, 2022

Howto

More info

github-actions bot commented Feb 8, 2022 • edited

feg-workflow

github-actions bot commented Feb 8, 2022 • edited

agw-workflow

github-actions bot commented Feb 14, 2022 • edited

Howto

github-actions bot commented Feb 16, 2022 • edited

Howto

sebathomas commented Feb 17, 2022

sebathomas left a comment

Choose a reason for hiding this comment

ardzoht left a comment

Choose a reason for hiding this comment

sebathomas commented Mar 17, 2022 • edited

sebathomas commented Mar 17, 2022

RahulKalsangra commented Mar 17, 2022

sebathomas commented Mar 17, 2022

RahulKalsangra commented Feb 8, 2022 •

edited by panyogesh

github-actions bot commented Feb 8, 2022 •

edited

github-actions bot commented Feb 8, 2022 •

edited

github-actions bot commented Feb 14, 2022 •

edited

github-actions bot commented Feb 16, 2022 •

edited

sebathomas commented Mar 17, 2022 •

edited