Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(orc8r): Split Metricsd to protected and southbound #11852

Merged
merged 1 commit into from Apr 20, 2022
Merged

refactor(orc8r): Split Metricsd to protected and southbound #11852

merged 1 commit into from Apr 20, 2022

Conversation

christinewang5
Copy link
Contributor

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label Feb 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels Feb 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022 •
edited

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

@christinewang5 christinewang5 changed the title Split metrics refactor(orc8r): Split Metricsd to protected and southbound Feb 28, 2022
@christinewang5 christinewang5 marked this pull request as ready for review February 28, 2022 22:49
@christinewang5 christinewang5 requested review from a team and themarwhal February 28, 2022 22:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022 •
edited

feg-workflow

    2 files  202 suites   38s ⏱️
370 tests 370 ✔️ 0 💤 0 ❌
384 runs  384 ✔️ 0 💤 0 ❌

Results for commit 4892145.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022 •
edited

cloud-workflow

    7 files  355 suites   2m 41s ⏱️
972 tests 972 ✔️ 0 💤 0 ❌

Results for commit 4892145.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022 •
edited

agw-workflow

     77 files     122 suites   7m 17s ⏱️
1 149 tests 1 140 ✔️ 9 💤 0 ❌
1 150 runs  1 141 ✔️ 9 💤 0 ❌

Results for commit f5b6fc0.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/XXL Denotes a Pull Request that changes 1000+ lines. labels Mar 11, 2022
@github-actions github-actions bot removed component: feg FEG-gateway related issues component: cwf labels Mar 11, 2022
@pull-request-size pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Mar 11, 2022
@christinewang5 christinewang5 force-pushed the split-metrics branch 2 times, most recently from 2bfd484 to b0b967e Compare March 28, 2022 05:16
hcgatewood
hcgatewood approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@hcgatewood hcgatewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, couple nits but otherwise msg when ready to merge

orc8r/cloud/go/services/metricsd/servicers/southbound/servicer.go Show resolved Hide resolved
orc8r/cloud/go/services/metricsd/servicers/protected/servicer.go Outdated Show resolved Hide resolved
orc8r/cloud/go/services/metricsd/exporters/remote_exporter.go Outdated Show resolved Hide resolved
hcgatewood
hcgatewood suggested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@hcgatewood hcgatewood left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops just kidding -- don't forget to add the new southbound servicer to the main.go as well!

(Both in main.go and in any test service startups)

orc8r/cloud/go/services/metricsd/metricsd/main.go Outdated Show resolved Hide resolved
@christinewang5 christinewang5 force-pushed the split-metrics branch 3 times, most recently from ba1b547 to aaea238 Compare April 14, 2022 17:08
@github-actions github-actions bot added the component: feg FEG-gateway related issues label Apr 14, 2022
@hcgatewood hcgatewood enabled auto-merge (squash) April 18, 2022 19:50
@hcgatewood hcgatewood enabled auto-merge (squash) April 18, 2022 19:50
@christinewang5 christinewang5 force-pushed the split-metrics branch 2 times, most recently from b8147b7 to f5b6fc0 Compare April 20, 2022 16:03
@christinewang5
refactor(orc8r): Split Metricsd to protected and southbound
4892145 
Signed-off-by: Christine Wang <christinewang@fb.com>
@hcgatewood hcgatewood merged commit d8879ff into magma:master Apr 20, 2022
@christinewang5 christinewang5 deleted the split-metrics branch April 21, 2022 14:50
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@christinewang5 @emakeev
refactor(orc8r): Split Metricsd to protected and southbound (magma#11852
d82be5a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcgatewood hcgatewood hcgatewood approved these changes

@themarwhal themarwhal themarwhal approved these changes

Assignees
No one assigned
Labels
component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue size/XL Denotes a Pull Request that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christinewang5 @hcgatewood @themarwhal