chore: fix mypy static type checking issues #12086

Neudrino · 2022-03-11T12:20:12Z

Summary

ℹ️ Commit wise review suggested.

Further cleanup for mypy introduction.
Follow up on:

Test Plan

Install mypy in a virtualenv and execute it via

cd $MAGMA_ROOT
mypy lte/gateway/python/

Before:

Found 14 errors in 6 files (checked 179 source files)

After:

Success: no issues found in 179 source files

github-actions · 2022-03-11T12:20:45Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-03-11T12:22:12Z

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

github-actions · 2022-03-11T12:22:51Z

Oops! Looks like you failed the Python Format Check.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

github-actions · 2022-03-11T12:29:30Z

feg-workflow

    2 files 202 suites 33s ⏱️
362 tests 362 ✔️ 0 💤 0 ❌
376 runs 376 ✔️ 0 💤 0 ❌

Results for commit eae44ba.

♻️ This comment has been updated with latest results.

Neudrino · 2022-03-11T13:07:43Z

lte/gateway/python/load_tests/common.py

@@ -84,7 +75,7 @@ def benchmark_grpc_request(
    output_file: str,
    num_reqs: int,
    address: str,
-    import_path: str = None,
+    import_path: str,


It turns out, that the import path is not actually optional, but always given by the caller.
I.e. the logic to "intelligently" determine some protobuf path can be removed.

github-actions · 2022-03-11T13:57:24Z

agw-workflow

  50 files   77 suites 5m 41s ⏱️
896 tests 887 ✔️ 9 💤 0 ❌
897 runs 888 ✔️ 9 💤 0 ❌

Results for commit eae44ba.

♻️ This comment has been updated with latest results.

pshelar

LGTM

lte/gateway/python/setup.py

lte/gateway/python/magma/kernsnoopd/handlers.py

lte/gateway/python/magma/kernsnoopd/snooper.py

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

github-actions · 2022-03-24T11:09:00Z

Unit Test Results

142 files 142 suites 1h 58m 31s ⏱️
292 tests 287 ✔️ 3 💤 1 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit f98b0b4.

♻️ This comment has been updated with latest results.

* chore: reduce mypy exclusion list Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com> * chore: import_path is always given and must not be optional Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com> * chore: exclude mypy warning Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com> * chore: fix mypy type issue Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com> * chore: fix mypy type issue Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com> * chore: fix mypy type issue Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com> * chore: fix mypy type issue Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 11, 2022

github-actions bot added the component: agw Access gateway-related issue label Mar 11, 2022

Neudrino force-pushed the ci/python-linter-fixes branch 8 times, most recently from 11e5526 to 8add81c Compare March 11, 2022 13:05

Neudrino commented Mar 11, 2022

View reviewed changes

Neudrino marked this pull request as ready for review March 11, 2022 16:59

Neudrino requested review from a team and pshelar March 11, 2022 16:59

pshelar approved these changes Mar 11, 2022

View reviewed changes

Neudrino requested a review from sebathomas March 11, 2022 17:25

nicarl reviewed Mar 12, 2022

View reviewed changes

lte/gateway/python/setup.py Outdated Show resolved Hide resolved

lte/gateway/python/magma/kernsnoopd/handlers.py Outdated Show resolved Hide resolved

lte/gateway/python/magma/kernsnoopd/snooper.py Outdated Show resolved Hide resolved

Neudrino added 7 commits March 15, 2022 11:19

chore: reduce mypy exclusion list

20f4970

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

chore: import_path is always given and must not be optional

e78368d

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

chore: exclude mypy warning

30d9dc9

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

chore: fix mypy type issue

c63f0dd

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

chore: fix mypy type issue

f9919d4

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

chore: fix mypy type issue

2eb5a6d

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

chore: fix mypy type issue

eae44ba

Signed-off-by: Fritz Lehnert <Fritz.Lehnert@tngtech.com>

Neudrino force-pushed the ci/python-linter-fixes branch from 8add81c to eae44ba Compare March 15, 2022 10:19

themarwhal approved these changes Mar 15, 2022

View reviewed changes

sebathomas approved these changes Mar 16, 2022

View reviewed changes

Neudrino added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Mar 21, 2022

nstng merged commit f98b0b4 into magma:master Mar 24, 2022

Neudrino deleted the ci/python-linter-fixes branch March 24, 2022 09:38

Neudrino mentioned this pull request Mar 24, 2022

chore(agw): fix mypy issues #12274

Merged

LKreutzer mentioned this pull request Oct 26, 2022

Investigate state of load_tests and relevance for bazel migration #13813

Closed

sebathomas mentioned this pull request Oct 26, 2022

fix: Restore import path logic in load tests #14287

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix mypy static type checking issues #12086

chore: fix mypy static type checking issues #12086

Neudrino commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022 •

edited

Neudrino Mar 11, 2022

github-actions bot commented Mar 11, 2022 •

edited

pshelar left a comment

github-actions bot commented Mar 24, 2022 •

edited

chore: fix mypy static type checking issues #12086

chore: fix mypy static type checking issues #12086

Conversation

Neudrino commented Mar 11, 2022 • edited

Summary

Test Plan

github-actions bot commented Mar 11, 2022

Howto

More info

github-actions bot commented Mar 11, 2022 • edited

Howto

github-actions bot commented Mar 11, 2022 • edited

Howto

github-actions bot commented Mar 11, 2022 • edited

feg-workflow

Neudrino Mar 11, 2022

Choose a reason for hiding this comment

github-actions bot commented Mar 11, 2022 • edited

agw-workflow

pshelar left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 24, 2022 • edited

Unit Test Results

Neudrino commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022 •

edited

github-actions bot commented Mar 11, 2022 •

edited

github-actions bot commented Mar 24, 2022 •

edited