Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restore import path logic in load tests #14287

Merged
merged 1 commit into from
Oct 27, 2022
Merged

fix: Restore import path logic in load tests #14287

merged 1 commit into from
Oct 27, 2022

Conversation

sebathomas
Copy link
Contributor

Summary

Too much logic was deleted to fix the typing in #12086. This restores the default path selection, which makes it possible to run load tests again.

Test Plan

Execute load tests:

vagrant@magma-dev:~/magma/lte/gateway/python/load_tests$ make load_test

Check mypy:

(python) vagrant@magma-dev:~/magma/lte/gateway$ mypy --ignore-missing-imports python/load_tests

Additional Information

  • This change is backwards-breaking

@sebathomas sebathomas requested a review from a team as a code owner October 26, 2022 16:06
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

@sebathomas sebathomas changed the title fix(test): Restore import path logic in load tests fix: Restore import path logic in load tests Oct 26, 2022
@sebathomas
fix: Restore import path logic in load tests
a9152d9 
Too much logic was deleted to fix the typing. This restores the
default path selection, which makes it possible to run load
tests again.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit a9152d9.

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 19s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit a9152d9.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 56s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit a9152d9.

LKreutzer
LKreutzer approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, lgtm!

@LKreutzer LKreutzer requested review from ajahl and removed request for koolzz October 27, 2022 07:49
@LKreutzer LKreutzer mentioned this pull request Oct 27, 2022
Closed
@voisey voisey merged commit 7f9bc5e into magma:master Oct 27, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@sebathomas @lucasgonze
fix: Restore import path logic in load tests (magma#14287)
6165d5c 
Too much logic was deleted to fix the typing. This restores the
default path selection, which makes it possible to run load
tests again.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

@voisey voisey voisey approved these changes

@LKreutzer LKreutzer LKreutzer approved these changes

@ajahl ajahl Awaiting requested review from ajahl

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebathomas @Neudrino @voisey @LKreutzer