Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reviewdog filter consolidation #12293

Merged
merged 1 commit into from Apr 27, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Mar 25, 2022

Summary

  • reduction of tech-depth for reviewdog workflow

Test Plan

Additional Information

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Mar 25, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Mar 25, 2022
@Neudrino Neudrino force-pushed the ci/reviewdog-consolidation branch 4 times, most recently from 94062fa to b35a4a3 Compare March 25, 2022 17:38
@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 25, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0
376 runs  376 ✔️ 0 💤 0

Results for commit 6a67912.

@magma magma deleted a comment from github-actions bot Mar 25, 2022
@magma magma deleted a comment from github-actions bot Mar 25, 2022
@github-actions github-actions bot removed the component: agw Access gateway-related issue label Mar 25, 2022
@Neudrino Neudrino force-pushed the ci/reviewdog-consolidation branch 3 times, most recently from a422890 to 8b67058 Compare April 22, 2022 14:34
@Neudrino Neudrino marked this pull request as ready for review April 22, 2022 15:03
@Neudrino Neudrino requested a review from a team as a code owner April 22, 2022 15:03
@Neudrino Neudrino requested a review from nstng April 22, 2022 15:03
.github/workflows/reviewdog-workflow.yml Outdated Show resolved Hide resolved
.github/workflows/reviewdog-workflow.yml Outdated Show resolved Hide resolved
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino requested a review from nstng April 27, 2022 16:19
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Neudrino Neudrino enabled auto-merge (squash) April 27, 2022 16:23
@Neudrino Neudrino merged commit 3e8b68f into magma:master Apr 27, 2022
@Neudrino Neudrino deleted the ci/reviewdog-consolidation branch April 27, 2022 18:28
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants