Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): consolidate linter implementations to use reviewdog for better Github integration #12553

Merged
merged 1 commit into from May 2, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Apr 25, 2022

Summary

  • add tflint to reviewdog to have this integrated with Github as well.

Test Plan

Additional information

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 25, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: orc8r Orchestrator-related issue labels Apr 25, 2022
@github-actions
Copy link
Contributor

cloud-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 26a79a9.

@github-actions github-actions bot removed the component: orc8r Orchestrator-related issue label Apr 25, 2022
@magma magma deleted a comment from github-actions bot Apr 27, 2022
@Neudrino Neudrino force-pushed the ci/reviewdog-for-terraform branch 3 times, most recently from cfa92bb to 6ea7642 Compare April 28, 2022 07:56
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Apr 28, 2022
@Neudrino Neudrino requested a review from nstng April 28, 2022 08:00
@Neudrino Neudrino marked this pull request as ready for review April 28, 2022 08:00
@Neudrino Neudrino requested a review from a team as a code owner April 28, 2022 08:00
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but PR title does not follow semantic commits format.

@maxhbr maxhbr self-requested a review April 28, 2022 08:30
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ci: is allowed, but I would prefer to have feat(ci): or fix(ci):.

I think ci should be used in the context of for example ci(orc8r): if you do ci work for orc8r. If a feature is added to ci it should be feat(ci).

... to allow for a nicer Github integration and increase CI consistency

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino changed the title ci: consolidate linter implementations to use reviewdog for better Github integration feat(ci): consolidate linter implementations to use reviewdog for better Github integration Apr 28, 2022
@Neudrino Neudrino requested a review from maxhbr April 28, 2022 17:06
@magma magma deleted a comment from Neudrino Apr 28, 2022
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neudrino Neudrino merged commit c2a5983 into magma:master May 2, 2022
@Neudrino Neudrino deleted the ci/reviewdog-for-terraform branch May 2, 2022 09:47
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
)

... to allow for a nicer Github integration and increase CI consistency

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants