New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): consolidate linter implementations to use reviewdog for better Github integration #12553
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
bed7239
to
cb6bfcc
Compare
cfa92bb
to
6ea7642
Compare
6ea7642
to
532c5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but PR title does not follow semantic commits format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ci:
is allowed, but I would prefer to have feat(ci):
or fix(ci):
.
I think ci
should be used in the context of for example ci(orc8r):
if you do ci work for orc8r. If a feature is added to ci it should be feat(ci)
.
... to allow for a nicer Github integration and increase CI consistency Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
532c5c4
to
b48b5a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Test Plan
Additional information