chore: Fully specify include paths for sessiond

[themarwhal]

Summary

This change was partially automated (by using Scott's full path refactoring script mentioned in #9961).

The changes are:

1. (manually done) Use < over " for protobuf includes
2. (partially automated with some manual fixes) Fix include directives to use the full path from magma root
3. (automated) Apply IWYU by running dev_tools/apply-iwyu.sh lte/gateway/c/session_manager in the devcontainer

Officially closes #8494 (the stale PR bot closed this already but we can officially resolve it)

Test Plan

CI (which includes build and unit test checks)

Next change

We will then rename all header files from .h to .hpp to better differentiate between C and C++ header files. This was already done by @electronjoe for the rest of C/C++ codebase.

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  202 suites   38s ⏱️
370 tests 370 ✔️ 0 💤 0 ❌
384 runs  384 ✔️ 0 💤 0 ❌

Results for commit 476b05f.

♻️ This comment has been updated with latest results.

[github-actions]

agw-workflow

    2 files      2 suites   3m 37s ⏱️
592 tests 583 ✔️ 9 💤 0 ❌
593 runs  584 ✔️ 9 💤 0 ❌

Results for commit 476b05f.

♻️ This comment has been updated with latest results.

[electronjoe]

As it seems that IWYU is working for session_manager now (it is?) - could we turn up CI automation for IWYU for this sub-directory?

[electronjoe]

Not looking to have you change your PR, but I'm wondering why these went to <> from ""? In the include fixup script I'm working on, I intended for repo-generated protos to use quotes (#12441).

[themarwhal]

ooo didn't realize. IWYU seems to default to <>, so I standardized on that. I don't have a preference either way as long as there is tooling around it to automate it :D

[GANESH-WAVELABS]

Can we fix these include ordering linter errors.

[themarwhal]

The include ordering in this PR was done by the IWYU script and since there is no automated way of appeasing cpplint right now, I would like to ignore these cpplint warnings for now. The hope is to eventually have an include sorting script that handles this (see #12441).

[GANESH-WAVELABS]

Ok Marie! Then its fine.

[GANESH-WAVELABS]

I have below minor comments.

1. There were some cpp linter errors, Let us fix at least include order related errors wherever applicable.

2. My concern is where does the *.pb.h or *.grpc.pb.h files to be included. Do we need to follow ([c/c++] Formatting tool for c/c++ Includes repo-wide #12441 ) and keep this at the end as mentioned in below image. Also these should be inside " " instead of < > as mentioned in one of comment in this PR.
   

3. Also shall we keep blank line for each distinct set of header files as mentioned in ([c/c++] Formatting tool for c/c++ Includes repo-wide #12441 )

Except above ordering / formatting issues, Changes Looks Good To Me!

[themarwhal]

I have below minor comments.

1. There were some cpp linter errors, Let us fix at least include order related errors wherever applicable.
2. My concern is where does the *.pb.h or *.grpc.pb.h files to be included. Do we need to follow ([c/c++] Formatting tool for c/c++ Includes repo-wide #12441 ) and keep this at the end as mentioned in below image. Also these should be inside " " instead of < > as mentioned in one of comment in this PR.
   
3. Also shall we keep blank line for each distinct set of header files as mentioned in ([c/c++] Formatting tool for c/c++ Includes repo-wide #12441 )

Except above ordering / formatting issues, Changes Looks Good To Me!

Thanks @GANESH-WAVELABS ! Those points all sound reasonable, but I think it will be much easier to address them once we have a script that can automate those fixes. I believe @electronjoe is working on this right now :) As for protobuf includes, I was hoping that the formatting script would eventually handle modifying '<' to '"' as well. But if that is not the case, I can modify those in this PR.

[GANESH-WAVELABS]

I have below minor comments.

1. There were some cpp linter errors, Let us fix at least include order related errors wherever applicable.
2. My concern is where does the *.pb.h or *.grpc.pb.h files to be included. Do we need to follow ([c/c++] Formatting tool for c/c++ Includes repo-wide #12441 ) and keep this at the end as mentioned in below image. Also these should be inside " " instead of < > as mentioned in one of comment in this PR.
   
3. Also shall we keep blank line for each distinct set of header files as mentioned in ([c/c++] Formatting tool for c/c++ Includes repo-wide #12441 )

Except above ordering / formatting issues, Changes Looks Good To Me!

Thanks @GANESH-WAVELABS ! Those points all sound reasonable, but I think it will be much easier to address them once we have a script that can automate those fixes. I believe @electronjoe is working on this right now :) As for protobuf includes, I was hoping that the formatting script would eventually handle modifying '<' to '"' as well. But if that is not the case, I can modify those in this PR.

Thanks Marie!! PR LGTM.