Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mme): fully specify orc8r/gw/c/core/oai/lib/... included paths #9961

Merged
merged 18 commits into from
Nov 1, 2021

Conversation

electronjoe
Copy link
Member

Summary

To be clear, this PR strictly maps include paths and has no intended functional impact.

This PR is one of many intended to migrate our C/C++ codebase to full repo-relative paths. See #9861.

Process

This PR was generated by using this go binary executed as follows:

go run ../../pathify.go -root /workspaces/magma/ -target /workspaces/magma/lte/gateway/c/core/oai/lib/sms_orc8r_client/ -dry_run=false -target_filter ".h,.c,.cpp"
... and many more

Additionally some CMake project changes were required. Namely I added $MAGMA_ROOT to the include path for each .../core/oai/lib/<sub-lib>/CMakeLists.txt in order to support absolute path references.

Test Plan

All builds and tests pass - compilation success is an overwhelming indicator of correct include modifications.

Signed-off-by: Scott Moeller electronjoe@gmail.com

Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
@pull-request-size pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label Oct 28, 2021
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Signed-off-by: Scott Moeller <electronjoe@gmail.com>
@pull-request-size pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/XXL Denotes a Pull Request that changes 1000+ lines. labels Oct 28, 2021
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue and removed size/XL Denotes a Pull Request that changes 500-999 lines. labels Oct 28, 2021
@github-actions
Copy link
Contributor

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 434ab62.

@github-actions
Copy link
Contributor

cloud-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 434ab62.

@electronjoe electronjoe marked this pull request as ready for review October 29, 2021 08:20
@electronjoe electronjoe requested review from a team and ulaskozat October 29, 2021 08:21
Copy link
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@electronjoe electronjoe merged commit 6ff5e36 into magma:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants