Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Address or remove all sessiond TODOs assigned to themarwhal #12594

Merged
merged 1 commit into from Apr 28, 2022

Conversation

themarwhal
Copy link
Member

Signed-off-by: GitHub noreply@github.com

Summary

Address or resolve TODOs assigned to @themarwhal

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: GitHub <noreply@github.com>
@themarwhal themarwhal requested review from a team and uri200 April 28, 2022 14:23
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Apr 28, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 410d7c0.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GANESH-WAVELABS GANESH-WAVELABS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@themarwhal themarwhal enabled auto-merge (squash) April 28, 2022 15:15
@themarwhal themarwhal changed the title chore: Address or remove all TODOs assigned to themarwhal chore: Address or remove all sessiond TODOs assigned to themarwhal Apr 28, 2022
@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   7m 17s ⏱️
1 158 tests 1 149 ✔️ 9 💤 0
1 159 runs  1 150 ✔️ 9 💤 0

Results for commit 410d7c0.

@themarwhal themarwhal merged commit 974bff4 into magma:master Apr 28, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants