Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pipelined): Fix selection of mypy errors #12875

Merged
merged 2 commits into from May 30, 2022
Merged

chore(pipelined): Fix selection of mypy errors #12875

merged 2 commits into from May 30, 2022

Conversation

mpfirrmann
Copy link
Contributor

Summary

This is a follow-up to #12833, focusing on encoding.py and further type annotation errors.
After the PR, the number of mypy --ignore-missing-imports magma/lte/gateway/python/magma/pipelined errors is decreased by 22.

Test Plan

on magma-dev:

  • bazel test lte/gateway/python/magma/pipelined/...
  • ./bazel/scripts/run_sudo_tests.sh lte/gateway/python/magma/pipelined/

Additional Information

  • This change is backwards-breaking

@mpfirrmann
mypy errors ’Need type annotation' are removed
1f18f2e 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann
mypy errors in 'encoding.py' are removed
93734c7 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann requested a review from a team May 30, 2022 12:07
@mpfirrmann mpfirrmann self-assigned this May 30, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 30, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label May 30, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs  385 ✔️ 0 💤 0 ❌

Results for commit 93734c7.

@github-actions
Copy link
Contributor

dp-workflow

  2 files    2 suites   4m 1s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌

Results for commit 93734c7.

@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   6m 30s ⏱️
1 151 tests 1 147 ✔️ 4 💤 0 ❌
1 152 runs  1 148 ✔️ 4 💤 0 ❌

Results for commit 93734c7.

nstng
nstng approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes discussed offline, run tests locally - LGTM
Extra ❤️ for the bazel test plan :)

@mpfirrmann mpfirrmann added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label May 30, 2022
@nstng nstng merged commit 7ea7292 into magma:master May 30, 2022
@mpfirrmann mpfirrmann deleted the mypy_typing_pipelined branch May 30, 2022 14:29
@voisey voisey mentioned this pull request May 31, 2022
Merged
2 tasks
@mpfirrmann mpfirrmann mentioned this pull request May 31, 2022
Merged
1 task
mpfirrmann added a commit to mpfirrmann/magma that referenced this pull request May 31, 2022
@mpfirrmann
chore(pipelined): Fix selection of mypy errors (magma#12875)
0b60c99 
* mypy errors ’Need type annotation' are removed

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

* mypy errors in 'encoding.py' are removed

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@mpfirrmann @emakeev
chore(pipelined): Fix selection of mypy errors (magma#12875)
1470ffc 
* mypy errors ’Need type annotation' are removed

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

* mypy errors in 'encoding.py' are removed

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstng nstng nstng approved these changes

@prabinakpattnaik prabinakpattnaik Awaiting requested review from prabinakpattnaik

Assignees

@mpfirrmann mpfirrmann

Labels
component: agw Access gateway-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpfirrmann @nstng