chore(pipelined): More mypy fixes #12884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
…atting" Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
sebathomas
reviewed
Jun 1, 2022
Comment on lines
+666
to
+667
| cookie (int): a hex cookie value for the request | ||
| cookie_mask (int): a hex cookie mask for the request |
There was a problem hiding this comment.
What does "hex" mean in this context?
There was a problem hiding this comment.
Good question. I meant things like this which is input to the function I've modified here, for example.
Note that Python seems to consider it to be an integer as I have declared here:
>>> OVS_COOKIE_MATCH_ALL = 0xffffffff
>>> type(OVS_COOKIE_MATCH_ALL)
<class 'int'>
though the built-in hex function actually returns strings:
>>> int(str(OVS_COOKIE_MATCH_ALL), 0)
4294967295
>>> hex(4294967295)
'0xffffffff'
There was a problem hiding this comment.
All right, so it is just an int for Python. I guess they write it in hexadecimal because the variable is used as a bitmask.
sebathomas
approved these changes
Jun 2, 2022
Comment on lines
+666
to
+667
| cookie (int): a hex cookie value for the request | ||
| cookie_mask (int): a hex cookie mask for the request |
There was a problem hiding this comment.
All right, so it is just an int for Python. I guess they write it in hexadecimal because the variable is used as a bitmask.
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* chore(pipelined): Remove commented out print statements Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> * chore(pipelined): Fix "Not all arguments converted during string formatting" Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> * chore(pipelined): Fix 'Function "builtins.hex" is not valid as a type' Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> * chore(pipelined): Fix incompatible argument with superclass Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> * chore(pipelined): Fix "Incompatible types in assignment" Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> * chore(pipelined): Remove more commented out code Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #12833 and #12875.
Test Plan
bazel test lte/gateway/python/magma/pipelined/..../bazel/scripts/run_sudo_tests.sh lte/gateway/python/magma/pipelined/