fix(nms): Make sure hot module replacement works for the e2e test #13572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
thmsschmitt
force-pushed
the
nms/hot-module-replacement-take-2
branch
from
33263a7
to
8a8a092
Compare
thmsschmitt
changed the title
thmsschmitt
changed the title
thmsschmitt
changed the title
thmsschmitt
commented
Aug 11, 2022
nms/babel.config.js
Outdated
| @@ -12,7 +12,7 @@ | |||
| */ | |||
|
|
|||
| function isWebpack(caller) { | |||
| return !!(caller && caller.name === 'web'); | |||
There was a problem hiding this comment.
caller.target was web so the plugin was never enabled. Somehow it work without, but I kept it because the docs say you should use it.
thmsschmitt
commented
Aug 11, 2022
| }; | ||
|
|
||
| void fetchNmsVersion(); | ||
| }); |
There was a problem hiding this comment.
prevent unnecessary requests
thmsschmitt
requested review from
Neudrino and
HannaFar
and removed request for
andreilee
Neudrino
approved these changes
Aug 11, 2022
magma#13559)" Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com> This reverts commit b2680c8.
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
thmsschmitt
force-pushed
the
nms/hot-module-replacement-take-2
branch
from
8a8a092
to
ea2377f
Compare
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This re-enables the hot module replacement as it was initially configured here #13559
The e2e tests were broken because there was an unhandled exception that lead to an overlay that blocked the UI. This has been fixed.
Test Plan