-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nms): Run e2e tests against prod build #13573
Merged
thmsschmitt
merged 1 commit into
magma:master
from
thmsschmitt:nms/run-e2e-tests-against-prod-build
Aug 11, 2022
Merged
feat(nms): Run e2e tests against prod build #13573
thmsschmitt
merged 1 commit into
magma:master
from
thmsschmitt:nms/run-e2e-tests-against-prod-build
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Denotes a Pull Request that changes 100-499 lines.
label
Aug 10, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the DCO check after the last commit. |
thmsschmitt
force-pushed
the
nms/run-e2e-tests-against-prod-build
branch
from
August 10, 2022 16:54
e533046
to
0ed25e3
Compare
Neudrino
approved these changes
Aug 11, 2022
thmsschmitt
force-pushed
the
nms/run-e2e-tests-against-prod-build
branch
2 times, most recently
from
August 11, 2022 14:04
7ee36fb
to
6a5e630
Compare
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
thmsschmitt
force-pushed
the
nms/run-e2e-tests-against-prod-build
branch
from
August 11, 2022 16:06
6a5e630
to
ee0cd21
Compare
pull-request-size
bot
added
size/XS
Denotes a PR that changes 0-9 lines.
and removed
size/L
Denotes a Pull Request that changes 100-499 lines.
labels
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the e2e test to run against the production build. The e2e test used to run against the dev build and the production build was never tested.
Test Plan
The e2e are green https://github.com/magma/magma/runs/7771874264?check_suite_focus=true