Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nms): Run e2e tests against prod build #13573

Merged

Conversation

thmsschmitt
Copy link
Contributor

@thmsschmitt thmsschmitt commented Aug 10, 2022

Summary

Changes the e2e test to run against the production build. The e2e test used to run against the dev build and the production build was never tested.

Test Plan

The e2e are green https://github.com/magma/magma/runs/7771874264?check_suite_focus=true

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Aug 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Aug 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ee0cd21.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ee0cd21.

♻️ This comment has been updated with latest results.

@thmsschmitt thmsschmitt force-pushed the nms/run-e2e-tests-against-prod-build branch from e533046 to 0ed25e3 Compare August 10, 2022 16:54
@thmsschmitt thmsschmitt marked this pull request as ready for review August 11, 2022 06:41
@thmsschmitt thmsschmitt requested review from a team, HannaFar and Neudrino August 11, 2022 06:41
@thmsschmitt thmsschmitt force-pushed the nms/run-e2e-tests-against-prod-build branch 2 times, most recently from 7ee36fb to 6a5e630 Compare August 11, 2022 14:04
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@thmsschmitt thmsschmitt force-pushed the nms/run-e2e-tests-against-prod-build branch from 6a5e630 to ee0cd21 Compare August 11, 2022 16:06
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Aug 11, 2022
@thmsschmitt thmsschmitt enabled auto-merge (squash) August 11, 2022 16:22
@thmsschmitt thmsschmitt merged commit 3d23d8a into magma:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants