fix(feg): fix snowflake issue in feg integ test #13600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
maxhbr
reviewed
Aug 12, 2022
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
db3e094
to
383f159
Compare
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
383f159
to
6cef0f6
Compare
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
6cef0f6
to
9c7b950
Compare
voisey
reviewed
Aug 17, 2022
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
9c7b950
to
00a0a43
Compare
voisey
approved these changes
Aug 18, 2022
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
2 times, most recently
from
a2b33d1
to
4b6e561
Compare
ajahl
reviewed
Aug 22, 2022
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
2 times, most recently
from
5cfb9bf
to
a17c588
Compare
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
2 times, most recently
from
b166dc3
to
5faf1ad
Compare
ajahl
approved these changes
Aug 23, 2022
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
5faf1ad
to
143c29a
Compare
jheidbrink
approved these changes
Aug 25, 2022
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
143c29a
to
6c5907f
Compare
|
Could someone from @magma/approvers-agw-integtests please take a look at this? It fixes the local running ot the FeG integ tests :) |
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Removes the snowflake file creation in $MAGMA_ROOT during the ci integ test. The correct snowflake file is still being created. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Fixes the incorrect creation of the snowflake file by introducing a `run.py` executable instead of using `docker-compose up -d`, which creates the file before docker tries to mount it. The usage is also changed in the corresponding fabfile for the automated workflow. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
fix_snowflake_issue_in_FeG_integ_test
branch
from
6c5907f
to
37f08b3
Compare
wolfseb
added
ready2merge
mpfirrmann
pushed a commit
to wolfseb/magma
that referenced
this pull request
Sep 5, 2022
* chore(feg): remove superfluous snowflake file Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * chore(ci): remove superfluous creation of a snowflake file Removes the snowflake file creation in $MAGMA_ROOT during the ci integ test. The correct snowflake file is still being created. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * docs: add changed commands to feg integ test documentation Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * fix(feg): fix snowflake file issue in feg integ test Fixes the incorrect creation of the snowflake file by introducing a `run.py` executable instead of using `docker-compose up -d`, which creates the file before docker tries to mount it. The usage is also changed in the corresponding fabfile for the automated workflow. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #13540
Merge after #13781
This PR creates a file
run.py, which is to be used instead ofdocker-compose up -dto start the FeG containers. It creates the snowflake file in/magma/.cache/feg/if it does not exist already (if there is a directorysnowflakein its place instead, it removes it first). Further related changes in this PR:./run.pylte/gateway/python/.cache/feg/Test Plan
magma/.cache/feg/snowflake/, the script will now automatically replace it with a snowflake file, which gets filled with an UUID.Additional Information