fix(ci): Fix broken feg integ tests. #13781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
crasu
changed the title
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
crasu
force-pushed
the
pr/fix-feg-integ-test-after-agw-containerization
branch
from
9965c35
to
99d6638
Compare
sebathomas
reviewed
Aug 30, 2022
| return InitMode.DOCKER | ||
| elif systemd_running: | ||
| return InitMode.SYSTEMD | ||
| else: | ||
| raise RuntimeError("Magmad is not running with either Docker or systemd") | ||
| return InitMode.SYSTEMD # default to systemd if both are running - needed by feg integ tests |
There was a problem hiding this comment.
Will it not just go into the docker_running branch in that case instead of defaulting to systemd? I think this branch is only reached if neither is running.
crasu
force-pushed
the
pr/fix-feg-integ-test-after-agw-containerization
branch
from
99d6638
to
e152340
Compare
sebathomas
approved these changes
Aug 30, 2022
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the DCO check after the last commit. |
crasu
force-pushed
the
pr/fix-feg-integ-test-after-agw-containerization
branch
from
43e5af0
to
aa70046
Compare
… for feg and systemd magmad for agw. So the detection fails. Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
crasu
force-pushed
the
pr/fix-feg-integ-test-after-agw-containerization
branch
from
aa70046
to
b5232aa
Compare
voisey
approved these changes
Aug 30, 2022
|
@VinashakAnkitAman Could you have a look? Currently the feg integ build is red. This should fix it. |
Sure, I will go through the changes now. |
1 task
1 task
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
… for feg and systemd magmad for agw. So the detection fails. (magma#13781) Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com> Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Feg integ tests need both magmad in docker for running the feg and magmad started by systemd for agw. So the detection which magmad to restart fails. We are now defaulting to systemd as it was before and we will probably have some kind of cli parameter for feg tests in the future to restart both magmads.
Test Plan
Test works on locally machine
Feg test run https://github.com/crasu/magma/actions/runs/2955993651.