Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bazel base image is pinned #13757

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Aug 26, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

This is the first PR for #13755 (see merge strategy in issue).

Note: the devcontainer image in .github/workflows/agw-workflow.yml should not be relevant because no bazel builds are executed on that image.

Test Plan

Additional Information

  • This change is backwards-breaking

…s a non breaking change

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng requested a review from a team August 26, 2022 14:43
@nstng nstng requested a review from a team as a code owner August 26, 2022 14:43
@nstng nstng requested a review from jheidbrink August 26, 2022 14:43
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 26, 2022
@nstng nstng requested review from LKreutzer and removed request for jheidbrink August 26, 2022 14:43
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 26, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit da8e861.

@nstng nstng linked an issue Aug 26, 2022 that may be closed by this pull request
Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - I think the change in the agw workflow is relevant because the bazel coverage should also build the targeted services.

@nstng
Copy link
Contributor Author

nstng commented Aug 26, 2022

I think the change in the agw workflow is relevant because the bazel coverage should also build the targeted services.

Is this regarding

Note: the devcontainer image in .github/workflows/agw-workflow.yml should not be relevant because no bazel builds are executed on that image.

Or are you saying there is something missing?

The note is regarding the devcontainer image that is used in the agw workflow. The devcontainer is build on top of the bazel base image. Nevertheless, imo we do not need to pin it for this release strategy, because no bazel builds are executed on that image.

@LKreutzer
Copy link
Contributor

The note is regarding the devcontainer image that is used in the agw workflow. The devcontainer is build on top of the bazel base image. Nevertheless, imo we do not need to pin it for this release strategy, because no bazel builds are executed on that image.

Nevermind - I did not see that you meant the devcontainer.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 44s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit da8e861.

@nstng nstng merged commit aae0287 into magma:master Aug 29, 2022
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
…s a non breaking change (magma#13757)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel Base and Magma VM are Using the same Folly version
2 participants