-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bazel base image is pinned #13757
Conversation
…s a non breaking change Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - I think the change in the agw workflow is relevant because the bazel coverage
should also build the targeted services.
Is this regarding
Or are you saying there is something missing? The note is regarding the devcontainer image that is used in the agw workflow. The devcontainer is build on top of the bazel base image. Nevertheless, imo we do not need to pin it for this release strategy, because no bazel builds are executed on that image. |
Nevermind - I did not see that you meant the devcontainer. |
…s a non breaking change (magma#13757) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
This is the first PR for #13755 (see merge strategy in issue).
Note: the devcontainer image in
.github/workflows/agw-workflow.yml
should not be relevant because no bazel builds are executed on that image.Test Plan
Additional Information