Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bazel base uses same folly version as magma vm #13867

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Sep 7, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

This PR re-applies #13743 (reverted in #13753). This time #13757 was applied before so that bazel workflows still run on the bazel base image before this change.

A follow-up PR will be created where the cache key in bazel workflows will be changed and the latest image is used again. By this, the cache failures that caused the revert should be prevented.

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng added the bazel changes for the Bazelification effort label Sep 7, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 7, 2022
@nstng nstng requested a review from LKreutzer September 7, 2022 15:25
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 3d7a81a.

@nstng nstng linked an issue Sep 7, 2022 that may be closed by this pull request
@nstng nstng merged commit 7673213 into magma:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

folly is aligned in bazel base and magma vm
2 participants