Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dp): Remove apt packages version pinning in DP Dockerfiles #13769

Merged
merged 1 commit into from Aug 29, 2022
Merged

chore(dp): Remove apt packages version pinning in DP Dockerfiles #13769

merged 1 commit into from Aug 29, 2022

Conversation

sklgromek
Copy link
Contributor

@sklgromek sklgromek commented Aug 29, 2022 •
edited

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Summary

To avoid dependency issues, when the base Docker image is updated, we shouldn't pin apt to a particular package version.

Test Plan

  • Check CI

Additional Information

  • This change is backwards-breaking

@sklgromek
chore(dp): Remove apt packages version pinning in DP Dockerfiles
45971ef 
Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
@sklgromek sklgromek requested review from a team and xbend August 29, 2022 11:55
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Aug 29, 2022
github-actions[bot]
github-actions bot reviewed Aug 29, 2022
View reviewed changes
dp/cloud/docker/python/configuration_controller/Dockerfile
@@ -1,7 +1,7 @@
ARG ENV=standard
FROM python:3.9.2-slim-buster as protos-generator

RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

dp/cloud/docker/python/radio_controller/Dockerfile
@@ -1,7 +1,7 @@
ARG ENV=standard
FROM python:3.9.2-slim-buster as protos-generator

RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

dp/cloud/docker/python/test_runner/Dockerfile
@@ -1,7 +1,7 @@
ARG ENV=standard
FROM python:3.9.2-slim-buster as protos-generator

RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 24s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 45971ef.

@xbend xbend mentioned this pull request Aug 29, 2022
Closed
1 task
xbend
xbend approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@xbend xbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ignoring hadolint remarks, hard pinning versions is ok, but we can reply on distro packaging here. Versions are not pinned/specified but those are system packages that should not change much within base release of the image.

@xbend xbend merged commit 77260f2 into magma:master Aug 29, 2022
@xbend xbend deleted the dp-remove-apt-packages-pinning branch August 29, 2022 15:24
@MagmaCIBot MagmaCIBot mentioned this pull request Aug 29, 2022
Merged
@MagmaCIBot
Copy link

💚 All backports created successfully

Status Branch Result
✅ v1.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

MagmaCIBot pushed a commit that referenced this pull request Aug 29, 2022
@sklgromek
chore(dp): Remove apt packages version pinning in DP Dockerfiles (#13769
d91964c 
)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
(cherry picked from commit 77260f2)
maxhbr pushed a commit that referenced this pull request Aug 30, 2022
@MagmaCIBot @sklgromek
chore(dp): Remove apt packages version pinning in DP Dockerfiles (#13769
a964ad7 
) (#13776)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
(cherry picked from commit 77260f2)

Co-authored-by: Tomasz Gromowski <tomasz@freedomfi.com>
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
@sklgromek @rsarwad
chore(dp): Remove apt packages version pinning in DP Dockerfiles (mag…
a79e78d 
…ma#13769)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
sklgromek added a commit to openEPC/magma that referenced this pull request Sep 15, 2022
@sklgromek @jkmar
chore(dp): Remove apt packages version pinning in DP Dockerfiles (mag…
bbb8976 
…ma#13769)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
jordanvrtanoski pushed a commit to jordanvrtanoski/magma that referenced this pull request Feb 8, 2023
@MagmaCIBot @sklgromek @jordanvrtanoski
chore(dp): Remove apt packages version pinning in DP Dockerfiles (mag…
d04086c 
…ma#13769) (magma#13776)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
(cherry picked from commit 77260f2)

Co-authored-by: Tomasz Gromowski <tomasz@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@xbend xbend xbend approved these changes

Assignees
No one assigned
Labels
apply-v1.8 candidate-for-backporting component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sklgromek @MagmaCIBot @xbend @maxhbr