Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.8] chore(dp): Remove apt packages version pinning in DP Dockerfiles (#13769) #13776

Merged
merged 1 commit into from Aug 30, 2022
Merged

[v1.8] chore(dp): Remove apt packages version pinning in DP Dockerfiles (#13769) #13776

merged 1 commit into from Aug 30, 2022

Conversation

MagmaCIBot
Copy link

Backport

This will backport the following commits from master to v1.8:

Questions ?

Please refer to the Backport tool documentation

@sklgromek
chore(dp): Remove apt packages version pinning in DP Dockerfiles (#13769
d91964c 
)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
(cherry picked from commit 77260f2)
@MagmaCIBot MagmaCIBot requested review from a team and m-trojanowski August 29, 2022 19:29
@MagmaCIBot MagmaCIBot mentioned this pull request Aug 29, 2022
Merged
2 tasks
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Aug 29, 2022
github-actions[bot]
github-actions bot reviewed Aug 29, 2022
View reviewed changes
dp/cloud/docker/python/configuration_controller/Dockerfile
@@ -1,7 +1,7 @@
ARG ENV=standard
FROM python:3.9.2-slim-buster as protos-generator

RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

dp/cloud/docker/python/radio_controller/Dockerfile
@@ -1,7 +1,7 @@
ARG ENV=standard
FROM python:3.9.2-slim-buster as protos-generator

RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

dp/cloud/docker/python/test_runner/Dockerfile
@@ -1,7 +1,7 @@
ARG ENV=standard
FROM python:3.9.2-slim-buster as protos-generator

RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

@maxhbr maxhbr merged commit a964ad7 into v1.8 Aug 30, 2022
@maxhbr maxhbr deleted the backport/v1.8/pr-13769 branch August 30, 2022 13:28
jordanvrtanoski pushed a commit to jordanvrtanoski/magma that referenced this pull request Feb 8, 2023
@MagmaCIBot @sklgromek @jordanvrtanoski
chore(dp): Remove apt packages version pinning in DP Dockerfiles (mag…
d04086c 
…ma#13769) (magma#13776)

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
(cherry picked from commit 77260f2)

Co-authored-by: Tomasz Gromowski <tomasz@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sklgromek sklgromek sklgromek approved these changes

@m-trojanowski m-trojanowski Awaiting requested review from m-trojanowski

Assignees

@sklgromek sklgromek

Labels
component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MagmaCIBot @sklgromek @maxhbr