fix(agw): fix certificate issue for containerized AGW deployment #13862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
a4fc463
to
7d38c7c
Compare
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
3 times, most recently
from
fceb588
to
25e7135
Compare
jheidbrink
approved these changes
Sep 15, 2022
wolfseb
added
DONOTLAND
ShubhamTatvamasi
approved these changes
Sep 20, 2022
voisey
reviewed
Sep 20, 2022
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
e99ef11
to
c38e530
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
c38e530
to
dd3cfd4
Compare
jheidbrink
reviewed
Sep 21, 2022
lte/gateway/docker/README.md
Outdated
| @@ -47,6 +47,13 @@ docker-compose build | |||
| docker-compose up | |||
| ``` | |||
|
|
|||
| Optional: If you want to connect to an orc8r, copy the `rootCA.pem` from the orc8r | |||
There was a problem hiding this comment.
I think this should happen before we run docker-compose up for the first time, so we should move this up.
There was a problem hiding this comment.
Since we mount the directory anyway I would have assumed that the order doesn't really matter, but I can change it if that is better
There was a problem hiding this comment.
I guess the AGW will read the certificate on startup and probably not re-read it when it is copied later when the AGW is already running.
There was a problem hiding this comment.
I have moved it before the docker setup.
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
dd3cfd4
to
3911d1e
Compare
jheidbrink
approved these changes
Sep 21, 2022
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
3911d1e
to
a4336b7
Compare
voisey
approved these changes
Sep 21, 2022
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
a4336b7
to
08f87bf
Compare
mpfirrmann
added
the
ready2merge
fixes the mount path for the rootCA.pem certificate, so a containerized deployment outside the dev VM can still access it Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
fix_certificate_issue_for_containerized_AGW_deployment
branch
from
08f87bf
to
6546140
Compare
3 tasks
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
…ma#13862) * fix(agw): fix certificate issue for containerized AGW deployment fixes the mount path for the rootCA.pem certificate, so a containerized deployment outside the dev VM can still access it Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * chore: add option to update rootCA.pem in deployment docs Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com
Summary
Resolves issue #13682.
This PR fixes the issue where a containerized deployment on bare metal tries to mount the
rootCA.pemcertificate from the directory$MAGMA_ROOT/.cache/test_certs/, which does not exist. Instead, it will be mounted from/var/opt/magma/certs/, where it is previously copied to when following the documentation.This should not affect the containerized AGW setup inside the dev VM, as spinning up the VM creates the certificate in both locations: at
$MAGMA_ROOT/.cache/test_certs/(mounted from host) and at/var/opt/magma/certs/in the VM.Test Plan
Additional Information