-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): all ROOTCA_PATH
variables are deleted
#14037
Conversation
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for unblocking CI - it should be analyzed if further ROOTCA_PATH
can/should be removed (44 findings in code).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com
Summary
With PR #13862, not all mentions of the
ROOTCA_PATH
in thedocker-compose.yaml
were deleted and running the containerized AGW did not work. Here, we remove the latest mention of the variable. This should enable CI workflows for the containerized AGW again, see a failing run i.e. HERE.Test Plan
Additional Information