Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): all ROOTCA_PATH variables are deleted #14037

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

mpfirrmann
Copy link
Contributor

@mpfirrmann mpfirrmann commented Sep 29, 2022

Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com

Summary

With PR #13862, not all mentions of the ROOTCA_PATH in the docker-compose.yaml were deleted and running the containerized AGW did not work. Here, we remove the latest mention of the variable. This should enable CI workflows for the containerized AGW again, see a failing run i.e. HERE.

Test Plan

  • Set up the containerized AGW (using the README) and
  • connect to an Orchestrator following (the latest version of) the Quick Start Guide.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann requested a review from a team September 29, 2022 12:59
@mpfirrmann mpfirrmann requested a review from a team as a code owner September 29, 2022 12:59
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 29, 2022
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for unblocking CI - it should be analyzed if further ROOTCA_PATH can/should be removed (44 findings in code).

@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit d4f62b5.

Copy link
Contributor

@crasu crasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpfirrmann mpfirrmann removed the request for review from 119Vik September 29, 2022 13:15
@crasu crasu enabled auto-merge (squash) September 29, 2022 13:15
@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 16s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit d4f62b5.

@crasu crasu merged commit ea91f38 into magma:master Sep 29, 2022
@mpfirrmann mpfirrmann deleted the pr/delete_rootca_path branch September 29, 2022 14:00
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants