Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Pin version of grpcio_tool in python_dev ansible role #13957

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

mpfirrmann
Copy link
Contributor

Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com

Summary

Follow up to #13946.
The grpcio_tool version is also pinned in the python_dev ansible role.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann mpfirrmann self-assigned this Sep 19, 2022
@mpfirrmann mpfirrmann requested review from a team and emakeev September 19, 2022 13:01
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 19, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Sep 19, 2022
@mpfirrmann mpfirrmann removed the request for review from emakeev September 19, 2022 13:03
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 821a96a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

dp-workflow

14 tests   14 ✔️  2m 11s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 821a96a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

cloud-workflow

1 135 tests   1 135 ✔️  2m 19s ⏱️
   365 suites         0 💤
       7 files           0

Results for commit 821a96a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

agw-workflow

615 tests   611 ✔️  5m 58s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 821a96a.

♻️ This comment has been updated with latest results.

@sebathomas
Copy link
Contributor

The other PR is merged now. This one should become green after a rebase.

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Sep 20, 2022
@sebathomas sebathomas merged commit a9c2f01 into magma:master Sep 20, 2022
@mpfirrmann mpfirrmann deleted the pr/pin_grpcio_tools branch September 21, 2022 15:39
mpfirrmann added a commit to wolfseb/magma that referenced this pull request Sep 21, 2022
…a#13957)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: orc8r Orchestrator-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants