fix(agw): Downgrade grpcio to fix pylint #13946

sebathomas · 2022-09-19T09:47:35Z

Summary

The latest version of grpcio released last week breaks the pylint test. I downgraded grpcio and grpcio-tools in

setup.py
build script
bazel setup

Bazel is not relevant for the pylint test but I wanted to keep the version boundaries consistent. Unfortunately, regenerating requirements.txt seems to have led to a lot of unrelated upgrades on the Bazel side. Not sure if this can be avoided but if they don't cause any issues it's probably okay.

Test Plan

The pylint test is green again. It runs as part of the PR's CI.

Additional Information

This change is backwards-breaking

github-actions · 2022-09-19T09:47:50Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-09-19T09:57:49Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit b128cb0.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-19T10:12:52Z

cloud-workflow

1 135 tests 1 135 ✔️ 2m 8s ⏱️
  365 suites       0 💤
      7 files       0 ❌

Results for commit b128cb0.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-19T10:13:04Z

dp-workflow

14 tests 14 ✔️ 2m 14s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit b128cb0.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-19T10:37:03Z

agw-workflow

615 tests 611 ✔️ 5m 17s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit cd50cec.

♻️ This comment has been updated with latest results.

mpfirrmann · 2022-09-19T11:41:19Z

Semi-related:
There is an installation step for grpcio-tools during the preburn of the python_dev ansible role (magma/orc8r/tools/ansible/roles/python_dev/tasks/main.yml). Maybe pin this one as well?

sebathomas · 2022-09-19T12:48:36Z

Semi-related: There is an installation step for grpcio-tools during the preburn of the python_dev ansible role (magma/orc8r/tools/ansible/roles/python_dev/tasks/main.yml). Maybe pin this one as well?

Removing this change again because it pulls in the orc8r approvers group which is hard to fulfill right now. 😞
(The other /orc8r/ files belong to both approvers-orc8r and approvers-agw so those should be fine.)

Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>

Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> (cherry picked from commit 1d34f11) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>

* fix(agw): Downgrade grpcio to fix pylint (#13946) Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> (cherry picked from commit 1d34f11) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: py cryptography is pinned to a version that works with magma (#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: workflows on 1.8 are pinned to relevant bazel base image and are using own cache key Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * fix(ci): node is pinned to version 17 that can be used on xenial (#14343) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit a03db0f) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Co-authored-by: Nils Semmelrock <42540177+nstng@users.noreply.github.com> Co-authored-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

* fix(agw): Downgrade grpcio to fix pylint (magma#13946) Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> (cherry picked from commit 1d34f11) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: py cryptography is pinned to a version that works with magma (magma#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: workflows on 1.8 are pinned to relevant bazel base image and are using own cache key Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * fix(ci): node is pinned to version 17 that can be used on xenial (magma#14343) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit a03db0f) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Co-authored-by: Nils Semmelrock <42540177+nstng@users.noreply.github.com> Co-authored-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 19, 2022

github-actions bot added component: agw Access gateway-related issue component: orc8r Orchestrator-related issue labels Sep 19, 2022

sebathomas force-pushed the fix-pylint branch from c5e9284 to f3cdcd7 Compare September 19, 2022 11:22

pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Sep 19, 2022

sebathomas marked this pull request as ready for review September 19, 2022 11:31

sebathomas requested a review from a team September 19, 2022 11:31

sebathomas requested a review from a team as a code owner September 19, 2022 11:31

sebathomas requested review from a team, electronjoe, ardzoht and maxhbr September 19, 2022 11:31

sebathomas force-pushed the fix-pylint branch from f3cdcd7 to cd50cec Compare September 19, 2022 11:44

jheidbrink approved these changes Sep 19, 2022

View reviewed changes

voisey approved these changes Sep 19, 2022

View reviewed changes

sebathomas enabled auto-merge (squash) September 19, 2022 12:08

fix(agw): Downgrade grpcio to fix pylint

b128cb0

Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>

sebathomas force-pushed the fix-pylint branch from cd50cec to b128cb0 Compare September 19, 2022 12:49

mpfirrmann mentioned this pull request Sep 19, 2022

fix(agw): Pin version of grpcio_tool in python_dev ansible role #13957

Merged

1 task

sebathomas merged commit 1d34f11 into magma:master Sep 19, 2022

nstng mentioned this pull request Sep 19, 2022

fix: py cryptography is pinned to a version that works with magma #13960

Merged

1 task

sebathomas mentioned this pull request Sep 26, 2022

fix(agw): Updated AGW Install script branch to v1.8 (#13996) [backport to v1.8] #13997

Merged

MoritzThomasHuebner mentioned this pull request Oct 12, 2022

fix: Backport fixes to v1.8 #14108

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(agw): Downgrade grpcio to fix pylint #13946

fix(agw): Downgrade grpcio to fix pylint #13946

sebathomas commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022

github-actions bot commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited

mpfirrmann commented Sep 19, 2022

sebathomas commented Sep 19, 2022

fix(agw): Downgrade grpcio to fix pylint #13946

fix(agw): Downgrade grpcio to fix pylint #13946

Conversation

sebathomas commented Sep 19, 2022 • edited

Summary

Test Plan

Additional Information

github-actions bot commented Sep 19, 2022

Howto

More info

github-actions bot commented Sep 19, 2022 • edited

feg-workflow

github-actions bot commented Sep 19, 2022 • edited

cloud-workflow

github-actions bot commented Sep 19, 2022 • edited

dp-workflow

github-actions bot commented Sep 19, 2022 • edited

agw-workflow

mpfirrmann commented Sep 19, 2022

sebathomas commented Sep 19, 2022

sebathomas commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited

github-actions bot commented Sep 19, 2022 •

edited