-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: py cryptography is pinned to a version that works with magma #13960
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
@@ -1011,7 +1007,7 @@ priority==1.3.0 \ | |||
--hash=sha256:6bc1961a6d7fcacbfc337769f1a382c8e746566aaa365e78047abe9f66b2ffbe \ | |||
--hash=sha256:be4fcb94b5e37cdeb40af5533afe6dd603bd665fe9c8b3052610fc1001d5d1eb | |||
# via -r requirements.in | |||
prometheus-client==0.3.1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, why did this one have a dash before?
@@ -979,7 +975,7 @@ oslo-config==8.8.0 \ | |||
--hash=sha256:96933d3011dae15608a11616bfb00d947e22da3cb09b6ff37ddd7576abd4764c \ | |||
--hash=sha256:b1e2a398450ea35a8e5630d8b23057b8939838c4433cd25a20cc3a36d5df9e3b | |||
# via -r requirements.in | |||
oslo-i18n==5.1.0 \ | |||
oslo.i18n==5.1.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems some naming scheme on pypi has changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I noticed too - lets see if ci is ok with this
@@ -25,7 +25,7 @@ bravado_core | |||
jsonschema==3.2.0 | |||
psutil | |||
systemd-python | |||
cryptography |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I think it would be nice to add a short comment with the reason why we need this restriction. Also, some more context in the PR description would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context in PR was in the writing during review :) comment in requirements.in, yes, good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
cd27bb4
to
bab2926
Compare
…gma#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
…gma#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
…gma#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
* fix(agw): Downgrade grpcio to fix pylint (#13946) Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> (cherry picked from commit 1d34f11) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: py cryptography is pinned to a version that works with magma (#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: workflows on 1.8 are pinned to relevant bazel base image and are using own cache key Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * fix(ci): node is pinned to version 17 that can be used on xenial (#14343) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit a03db0f) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Co-authored-by: Nils Semmelrock <42540177+nstng@users.noreply.github.com> Co-authored-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
* fix(agw): Downgrade grpcio to fix pylint (magma#13946) Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> (cherry picked from commit 1d34f11) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: py cryptography is pinned to a version that works with magma (magma#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: workflows on 1.8 are pinned to relevant bazel base image and are using own cache key Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * fix(ci): node is pinned to version 17 that can be used on xenial (magma#14343) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit a03db0f) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Co-authored-by: Nils Semmelrock <42540177+nstng@users.noreply.github.com> Co-authored-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
* fix(agw): Downgrade grpcio to fix pylint (magma#13946) Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> (cherry picked from commit 1d34f11) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: py cryptography is pinned to a version that works with magma (magma#13960) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit c89642a) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * fix: workflows on 1.8 are pinned to relevant bazel base image and are using own cache key Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * fix(ci): node is pinned to version 17 that can be used on xenial (magma#14343) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> (cherry picked from commit a03db0f) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Co-authored-by: Nils Semmelrock <42540177+nstng@users.noreply.github.com> Co-authored-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
cryptography for bazel was upgraded to
38.0.1
(from37.0.4
) with #13946. This was not visible in the PR CI because it causes a runtime issue with magmad that is only seen in the integration tests.Test Plan
bazel run orc8r/gateway/python/magma/magmad
and see that error above does not happenAdditional Information