chore(agw): remove docker-compose.dev.file #14050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
|
Did you test the case of a production setup? I guess the variable is not set and then it just works and it's also not set in the containers? Edit: Discussed in person that it works if the variable is not set. |
maxhbr
reviewed
Oct 1, 2022
jheidbrink
reviewed
Oct 5, 2022
voisey
reviewed
Oct 11, 2022
| @@ -161,6 +174,8 @@ services: | |||
| retries: 3 | |||
| cap_add: | |||
| - NET_RAW | |||
| environment: | |||
| MAGMA_DEV_MODE: ${MAGMA_DEV_MODE} | |||
| command: /usr/bin/env python3 -m magma.monitord.main | |||
|
|
|||
| redirectd: | |||
There was a problem hiding this comment.
Is there a reason it isn't needed for redirectd?
There was a problem hiding this comment.
Its probably not needed for a lot of other service as well. But I only removed it from service where I know from the top of my head it wasn't required.
There was a problem hiding this comment.
Okay, sure. Maybe you could open an issue when this gets merged to remove any other unnecessary ones?
crasu
force-pushed
the
pr/kill-docker-compose-dev-yaml
branch
from
894a1c1
to
c1d4ebe
Compare
voisey
approved these changes
Oct 11, 2022
added 3 commits
October 12, 2022 08:56
Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
…ntainerized integ tests Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
crasu
force-pushed
the
pr/kill-docker-compose-dev-yaml
branch
from
9bdb216
to
211bc8e
Compare
Neudrino
added a commit
to Neudrino/magma
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Neudrino
added a commit
that referenced
this pull request
Oct 12, 2022
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Oct 13, 2022
magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com> feat(agw): time before killing containers during restart is reduced as (magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com> feat(agw): time before killing containers during restart is reduced as (magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> fix(ci): there was a bit too much deleted in magma#14050 (magma#14143) Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The docker-compose.dev.file is redundant. This pr removes it.
Test Plan