feat(agw): Kill hanging containers immediatly for dockerized agw integ tests #14139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
mpfirrmann
approved these changes
Oct 12, 2022
voisey
approved these changes
Oct 12, 2022
otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
crasu
force-pushed
the
pr/kill-agw-docker-containers-immediately-in-integ-tests
branch
from
122b550
to
00ac606
Compare
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Oct 13, 2022
magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Oct 13, 2022
magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com> feat(agw): time before killing containers during restart is reduced as (magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Oct 13, 2022
magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com> feat(agw): time before killing containers during restart is reduced as (magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> Addressed review comment Signed-off-by: Rashmi <rashmi.sarwad@radisys.com> feat(agw): time before killing containers during restart is reduced as (magma#14139) otherwise hanging containers take up to 20s to restart and tests run into timeouts. Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Co-authored-by: Marco Pfirrmann <christian.kraemer@tngtech.com> fix(ci): there was a bit too much deleted in magma#14050 (magma#14143) Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise hanging containers take up to 20s to restart and tests run into timeouts.
Tests
Containerized LTE integ test run: https://github.com/crasu/magma/actions/runs/3233773458/jobs/5296052060